Skip to content

Initialize authentication popup modal only when needed #30647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Dec 22, 2022
Merged

Initialize authentication popup modal only when needed #30647

merged 26 commits into from
Dec 22, 2022

Conversation

krzksz
Copy link
Contributor

@krzksz krzksz commented Oct 25, 2020 •
edited by engcom-Charlie
Loading

Description (*)

This PR is somehow an evolution of the #27686 in which I have found that it is not possible to completely skip initialization of authentication popup. That said, by adding this additional check, we are able to save a lot of CPU time for all of the shops that have guest checkout enabled.

Related Pull Requests

magento/inventory#3261
https://github.com/magento/partners-magento2ee/pull/428

Here are the profiles of before:
auth-popup-before
and after:
auth-popup-after

Manual testing scenarios (*)

  1. setModalElement function is no longer called when guest checkout is enabled.
  2. Authentication popup still shows properly when guest user tries to go to the checkout but guest checkout is disabled.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

Resolved issues:

  1. resolves [Issue] Initialize authentication popup modal only when needed #30672: Initialize authentication popup modal only when needed

@m2-assistant
Copy link

m2-assistant bot commented Oct 25, 2020

Hi @krzksz. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@krzksz krzksz added the Area: Perf/Frontend All tickets related with improving frontend performance. label Oct 25, 2020
@mrtuvn
Copy link
Contributor

mrtuvn commented Oct 25, 2020

Nice works. This pr will make magento more become better place

@krzksz
Copy link
Contributor Author

krzksz commented Oct 25, 2020

@magento run all tests

@mrtuvn
Copy link
Contributor

mrtuvn commented Oct 25, 2020 •
edited
Loading

Can you add minimal dependency js like closed PR 27686. Seem current authen-popup require a lot another components
CC: @krzksz

ihor-sviziev
ihor-sviziev approved these changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like your changes causing regression. Could you review test failures and adjust your code accordingly?

ihor-sviziev
ihor-sviziev requested changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like your changes causing regression. Could you review test failures and adjust your code accordingly?

@magento-engcom-team
Copy link
Contributor

Hi @ihor-sviziev, thank you for the review.
ENGCOM-8387 has been created to process this Pull Request
✳️ @ihor-sviziev, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 26, 2020
@sidolov sidolov added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Oct 27, 2020
@sidolov
Copy link
Contributor

sidolov commented Oct 27, 2020

@magento create issue

@m2-assistant m2-assistant bot mentioned this pull request Oct 27, 2020
Closed
4 tasks
@ihor-sviziev
Copy link
Contributor

@magento run all tests

@engcom-Echo
Copy link
Contributor

@magento run all tests

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests EE, Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@engcom-Echo
Copy link
Contributor

@magento run Functional Tests B2B

@magento-automated-testing
Copy link

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

@sinhaparul sinhaparul added the Project: Community Picked PRs upvoted by the community label Nov 8, 2022
@sinhaparul sinhaparul added Project: Community Picked PRs upvoted by the community and removed Project: Community Picked PRs upvoted by the community labels Nov 8, 2022
@engcom-Echo
Copy link
Contributor

Seems like bot moved this PR from Merge in Progress to Ready for Testing. Moving back to merge in progress.

@sinhaparul sinhaparul added Project: Community Picked PRs upvoted by the community and removed Project: Community Picked PRs upvoted by the community labels Nov 10, 2022
@magento-devops-reposync-svc magento-devops-reposync-svc merged commit 2593a4e into magento:2.4-develop Dec 22, 2022
@ihor-sviziev
Copy link
Contributor

Finally! This or got 2 birthdays and almost 1 month, and only then merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrtuvn mrtuvn mrtuvn left review comments

@gabrieldagama gabrieldagama gabrieldagama requested changes

@Den4ik Den4ik Den4ik approved these changes

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

@sidolov sidolov sidolov approved these changes

Assignees

@Den4ik Den4ik

@ihor-sviziev ihor-sviziev

@gabrieldagama gabrieldagama

@sidolov sidolov

@engcom-Alfa engcom-Alfa

@engcom-Charlie engcom-Charlie

@engcom-Delta engcom-Delta

Labels
Area: Frontend Area: Perf/Frontend All tickets related with improving frontend performance. Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: category of expertise Component: Captcha Component: Checkout Component: CheckoutAgreements Component: Customer Component: Multishipping Component: Newsletter Component: Tax Partner: creativestyle partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: accept Project: Community Picked PRs upvoted by the community QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Initialize authentication popup modal only when needed