JS error in the customer data

[ihor-sviziev]

Originally this issue was reported in 5983e17#commitcomment-44080850 by @HenKun.

The following commit 5983e17 leads to similar issues described in #24847.

Preconditions (*)

1. Magento 2.4.1, or 2.4-develop

Steps to reproduce (*)

1. Add the following code to the page on frontend:

<script>
    require(['Magento_Customer/js/customer-data'], function (customerData) {
        console.log(customerData.getExpiredSectionNames());
    });
</script>

2. Go to the frontend, see the console

Expected result (*)

1. In the console you should see an empty array, like this:
   

Actual result (*)

1. in the console we see the following error:
   

Additional info from Engcom

Add the script to, for example, /app/code/Magento/Customer/view/frontend/templates/form/edit.phtml

1. In the Storefront, Sign In as a Customer
2. Go to My Account
3. Click Edit under Contact Information
4. Observe the dev console

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @ihor-sviziev. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hello @ihor-sviziev

Thank you for your report. We Confirm that the issue is reproducible on the latest 2.4-develop. Additional info is added to the description.

[magento-engcom-team]

✅ Confirmed by @engcom-Bravo
Thank you for verifying the issue. Based on the provided information internal tickets MC-40701 were created

Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[ihor-sviziev]

Re-opened since it was reverted. #31920 (comment)

[engcom-Bravo]

Hi @ihor-sviziev,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshost.

Steps to reproduce

1.Add the following code to the page on frontend:

<script>
    require(['Magento_Customer/js/customer-data'], function (customerData) {
        console.log(customerData.getExpiredSectionNames());
    });
</script>

2.Go to the frontend, see the console

In Console we are getting Error.

Hence confirming this issue.

Thanks.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7501 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[kanevbg]

up, 2.4.x-develop seems to still produce the error (tested with firefox).

[AndresInSpace]

It appears this has not been fully addressed.
The patch added a check for storage, at https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Customer/view/frontend/web/js/customer-data.js#L272

Needs same check at https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Customer/view/frontend/web/js/customer-data.js#L263
as it's within the same method getExpiredSectionNames

Additionally customer-data has a race condition with its mixin and the events (eg AjaxComplete event)
Events are added to document before the mixin is loaded due to customer-data loading for the mixin to be applied, then an ajax event fires before mixin is loaded (requirejs settimeout).

Since the mixin is what initializes the storage property, when the ajaxcomplete happens before the mixin is loaded it calls invalidate method which calls-> buffer.remove-> for each section calls-> storage.remove and errors out (storage undefined).

This is mainly happening when third-party scripts are making ajax calls due to them not using require call because they are not dependent on magento scripts, or if it is magento dependent then customer-data is not included in dep array in require call or the ajax event does not have global set to false..

Setting global false on ajax request is not a proper fix if they do want it to be intercepted, just not by customer-data..

Edit:
I believe I have a fix for the requirejs issue causing the mixin to fail to load, which is what is ultimately causing this error in customer-data for undefined storage prop. See #33593 (comment)