Re-apply fix for JS error in the customer data #36177

TuVanDev · 2022-09-22T07:14:41Z

Description (*)

The fixes for issue #31920 in PR 31940 were removed accidentally. This PR revert code changes in PR 31940 for fixing errors in customer data when component is not initialized.

Related Pull Requests

31940

Related Commits

Fixed Issues (if relevant)

Fixes JS error in the customer data #31920

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Revert code changes for fixing errors in customer data when component is not initialized - accident removed in a previous commit

m2-assistant · 2022-09-22T07:14:44Z

Hi @Viper9x. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests
Semantic Version Checker

You can find more information about the builds here

ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

TuVanDev · 2022-09-22T07:15:08Z

@magento run all tests

magento-automated-testing · 2022-09-22T07:15:17Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-22T10:31:14Z

@magento run Functional Tests B2B,Functional Tests CE,Functional Tests EE,Unit Tests

magento-automated-testing · 2022-09-22T10:31:19Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-22T16:44:43Z

@magento run Functional Tests B2B,Unit Tests

magento-automated-testing · 2022-09-22T16:44:51Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-23T01:16:45Z

@magento run Functional Tests B2B,Unit Tests

magento-automated-testing · 2022-09-23T01:16:53Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-23T04:11:20Z

@magento run Unit Tests

magento-automated-testing · 2022-09-23T04:11:27Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-23T07:40:53Z

@magento run Unit Tests

magento-automated-testing · 2022-09-23T07:40:57Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-23T08:39:44Z

@magento run Unit Tests

magento-automated-testing · 2022-09-23T08:39:52Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-23T13:30:52Z

@magento run Unit Tests

magento-automated-testing · 2022-09-23T13:30:58Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-23T15:44:13Z

@magento run Unit Tests

magento-automated-testing · 2022-09-23T15:44:21Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-23T17:17:22Z

@magento run Unit Tests

magento-automated-testing · 2022-09-23T17:17:29Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

TuVanDev · 2022-09-23T18:15:33Z

@magento run all tests

mrtuvn · 2023-02-10T04:51:38Z

@magento run all tests

magento-automated-testing · 2023-02-10T04:51:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

AshishKumarPundeer · 2023-02-15T15:03:29Z

@Viper9x @ihor-sviziev
Thanks for the collaboration & contribution!

✖️ QA Failed

Re-apply fix for JS error in the customer data

Manual Scenario Steps

After taking the PR changes we have checked the issue got fixed. But for the scenario we are still able to reproduce the same. Please find the attached screenshot for you references.

Before taking the PR changes

After taking the PR changes

engcom-Charlie · 2023-02-15T16:49:53Z

As per this comment, moving it to Changes Requested.

Thank you!

ihor-sviziev · 2023-02-16T10:45:38Z

So looks like if we can't accept these changes, we should always wrap our code in

customerData.getInitCustomerData().done(function () {
    // .. my code there
});

AshishKumarPundeer · 2023-02-17T13:56:16Z

@ihor-sviziev and @Viper9x we are working on mentioned failure.

Thank you

engcom-Charlie · 2023-02-22T08:52:45Z

Pushed the code fix for mentioned issue on behalf of @AshishKumarPundeer

Thank you!

AshishKumarPundeer · 2023-02-22T09:23:34Z

@magento run all tests

magento-automated-testing · 2023-02-22T09:23:44Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

AshishKumarPundeer · 2023-02-22T11:55:58Z

@magento run Functional Tests EE

magento-automated-testing · 2023-02-22T11:56:08Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

AshishKumarPundeer · 2023-02-23T04:54:59Z

@magento run Functional Tests EE

magento-automated-testing · 2023-02-23T04:55:09Z

The requested builds are added to the queue. You should be able to see them here within a few minutes. Please re-request them if they don't show in a reasonable amount of time.

AshishKumarPundeer · 2023-02-23T07:06:38Z

Functional Tests EE failures are different on last two run
Run1

Run2

Hence moving to further process

engcom-Charlie · 2023-02-24T12:41:08Z

Hi @Viper9x and @ihor-sviziev,

Thank you for the contribution!

I have tested the issue with the PR changes and it’s working fine . Also the above mentioned regression is not occurring now.

✔️ QA Passed

Steps to reproduce

Add the following code to the page on frontend:

<script>
    require(['Magento_Customer/js/customer-data'], function (customerData) {
        console.log(customerData.getExpiredSectionNames());
    });
</script>

Visit the storefront, check the console

Before: ✖️

After: ✔️

"mage-cache-storage" cookie expiration date is now getting updated after "Cookie Lifetime" is changed.

As the PR is now working as expected, moving it to Merge in Progress.

Thank you!

Revert changes for fixing JS errors in customer data

847c799

Revert code changes for fixing errors in customer data when component is not initialized - accident removed in a previous commit

m2-community-project bot added the Progress: pending review label Sep 22, 2022

TuVanDev referenced this pull request Sep 22, 2022

cookie expiration date is not updated after Cookie Lifetime is changed

405ee6e

sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 22, 2022

Merge branch '2.4-develop' into patch-1

8e96369

engcom-Charlie self-assigned this Feb 15, 2023

m2-community-project bot added Progress: needs update and removed Progress: ready for testing labels Feb 15, 2023

engcom-Charlie added 2 commits February 22, 2023 12:58

Merge remote-tracking branch 'magento/2.4-develop' into patch-1

001e814

Fixed the issue of mage-cache-storage

3a90950

ihor-sviziev approved these changes Feb 23, 2023

View reviewed changes

m2-community-project bot added Progress: ready for testing and removed Progress: needs update labels Feb 23, 2023

m2-community-project bot added Progress: accept and removed Progress: ready for testing labels Feb 24, 2023

magento-devops-reposync-svc merged commit 14165c1 into magento:2.4-develop Mar 2, 2023

Re-apply fix for JS error in the customer data #36177

Re-apply fix for JS error in the customer data #36177

Conversation

TuVanDev commented Sep 22, 2022 • edited Loading

Description (*)

Related Pull Requests

Related Commits

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

m2-assistant bot commented Sep 22, 2022

TuVanDev commented Sep 22, 2022

magento-automated-testing bot commented Sep 22, 2022

TuVanDev commented Sep 22, 2022

magento-automated-testing bot commented Sep 22, 2022

TuVanDev commented Sep 22, 2022

magento-automated-testing bot commented Sep 22, 2022

TuVanDev commented Sep 23, 2022

magento-automated-testing bot commented Sep 23, 2022

TuVanDev commented Sep 23, 2022

magento-automated-testing bot commented Sep 23, 2022

TuVanDev commented Sep 23, 2022

magento-automated-testing bot commented Sep 23, 2022

TuVanDev commented Sep 23, 2022

magento-automated-testing bot commented Sep 23, 2022

TuVanDev commented Sep 23, 2022

magento-automated-testing bot commented Sep 23, 2022

TuVanDev commented Sep 23, 2022

magento-automated-testing bot commented Sep 23, 2022

TuVanDev commented Sep 23, 2022

magento-automated-testing bot commented Sep 23, 2022

TuVanDev commented Sep 23, 2022

mrtuvn commented Feb 10, 2023

magento-automated-testing bot commented Feb 10, 2023

AshishKumarPundeer commented Feb 15, 2023 • edited by engcom-Echo Loading

engcom-Charlie commented Feb 15, 2023

ihor-sviziev commented Feb 16, 2023 • edited Loading

AshishKumarPundeer commented Feb 17, 2023

engcom-Charlie commented Feb 22, 2023

AshishKumarPundeer commented Feb 22, 2023

magento-automated-testing bot commented Feb 22, 2023

AshishKumarPundeer commented Feb 22, 2023

magento-automated-testing bot commented Feb 22, 2023

AshishKumarPundeer commented Feb 23, 2023

magento-automated-testing bot commented Feb 23, 2023

AshishKumarPundeer commented Feb 23, 2023

engcom-Charlie commented Feb 24, 2023

TuVanDev commented Sep 22, 2022 •

edited

Loading

AshishKumarPundeer commented Feb 15, 2023 •

edited by engcom-Echo

Loading

ihor-sviziev commented Feb 16, 2023 •

edited

Loading