Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classes and interfaces part 3 #32059

Open
sivaschenko opened this issue Feb 9, 2021 · 4 comments
Open

Update classes and interfaces part 3 #32059

sivaschenko opened this issue Feb 9, 2021 · 4 comments
Labels
Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Project: API Changes Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Milestone

Comments

@sivaschenko
Copy link
Member

sivaschenko commented Feb 9, 2021

Update the following classes and interfaces in 2.5-develop branch:

  1. Magento\Checkout\Model\Type\Onepage Create a new interface and move constants there. Current class must implement the new interface to maintain backward compatibility
  2. Magento\Framework\Image\AdapterFactory Change visibility of protected properties to private
  3. Magento\Catalog\Model\Config Change visibility of protected properties/methods to private
  4. Magento\Customer\Model\CustomerRegistry Change visibility of protected properties/methods to private
  5. Magento\Quote\Setup\QuoteSetup Change visibility of protected properties/methods to private
  6. Magento\Ui\Component\Control\Container Change visibility of createButton() method to private
  7. Magento\Catalog\Model\Layer\Filter\Item Change visibility of protected properties/methods to private
@sivaschenko sivaschenko added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes labels Feb 9, 2021
@sivaschenko sivaschenko added this to the 2.5 milestone Feb 9, 2021
@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2021

Hi @sivaschenko. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@ProkopovVitaliy
Copy link
Contributor

@magento i am working on this

@Usik2203
Copy link
Contributor

@magento I am working on this

@gabrieldagama gabrieldagama changed the title Update classes and interfaces and mark them as API part 3 Update classes and interfaces part 3 Apr 6, 2021
@engcom-Oscar engcom-Oscar added Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Apr 16, 2021
@engcom-Oscar engcom-Oscar added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Apr 16, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41934 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Framework/Api USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog Service Contracts use just Catalog Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for dev Project: API Changes Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants