[32059] [To 2.4-develop] Update classes and interfaces and mark them as API part 3

[Usik2203]

Description (*)

This PR fixes #32059

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Update classes and interfaces part 3 #32059

[m2-assistant]

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE,
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[Usik2203]

@magento run all tests

[danielrussob]

Hello @Usik2203 ,
files are different from #32059 can you have a double check please?

[Usik2203]

Hello @Usik2203 ,
files are different from #32059 can you have a double check please?

Hi @danielrussob
I double checked . Everything is ok for me
Thanks

[magento-engcom-team]

Hi @aleron75, thank you for the review.
ENGCOM-9022 has been created to process this Pull Request
✳️ @aleron75, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[engcom-Foxtrot]

SVC failures should be approved.

[danielrussob]

Hello @Usik2203 ,
thank you for your contribution but according to guidelines you cannot change protected member to private in the same lane 2.4.x cause it's a breaking change

[Usik2203]

Hello @Usik2203 ,
thank you for your contribution but according to guidelines you cannot change protected member to private in the same lane 2.4.x cause it's a breaking change

Hi @danielrussob
Thank you for review ,
These changes (changing protected member to private) were requested in this issue #32059

Also this PR should be target to 2.4-develop based on massages in Slack channel #api-changes-project

We have had some discussions internally and have made a decision, we will be splitting this project in 2 phases (or milestone if you prefer), these phases will be:
Mark all required classes/interfaces with @api tag
Perform the refactors that will actually impact code

Also, the first phase of this project will be delivered to 2.4-develop, not 2.5 anymore, the second phase is under discussion still

I will be reviewing all the issues and make sure we split these 2 types of work

After that, I would need your help to recreate these PRs to 2.4-develop, we likely will need to create a new branch from 2.4-develop, cherry pick your commits and create a new PR

Based on this information I think that changes are corect

cc @gabrieldagama

[danielrussob]

Hello @Usik2203 ,
thank you for your contribution but according to guidelines you cannot change protected member to private in the same lane 2.4.x cause it's a breaking change

Hi @danielrussob
Thank you for review ,
These changes (changing protected member to private) were requested in this issue #32059

Also this PR should be target to 2.4-develop based on massages in Slack channel #api-changes-project

We have had some discussions internally and have made a decision, we will be splitting this project in 2 phases (or milestone if you prefer), these phases will be:
Mark all required classes/interfaces with @api tag
Perform the refactors that will actually impact code

Also, the first phase of this project will be delivered to 2.4-develop, not 2.5 anymore, the second phase is under discussion still

I will be reviewing all the issues and make sure we split these 2 types of work

After that, I would need your help to recreate these PRs to 2.4-develop, we likely will need to create a new branch from 2.4-develop, cherry pick your commits and create a new PR
Based on this information I think that changes are corect

cc @gabrieldagama

OK, waiting @gabrieldagama !

[gabrieldagama]

Hi @Usik2203 @danielrussob we already marked these classes as API on api-changes-develop branch, the changes to it's properties must be done on 2.5 release line.

[m2-assistant]

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.