Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[32059] Update classes and interfaces and mark them as API part 3 #32184

Closed
wants to merge 3 commits into from

Conversation

Usik2203
Copy link
Contributor

Description (*)

This PR fixes #32059

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes Update classes and interfaces part 3 #32059

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Feb 16, 2021

Hi @Usik2203. Thank you for your contribution
Here are some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.5-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Feb 16, 2021
@magento-engcom-team magento-engcom-team added Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner labels Feb 16, 2021
@BarnyShergold
Copy link

@magento run Unit Tests,WebAPI Tests

@eduard13 eduard13 added this to the 2.5 milestone Feb 18, 2021
@eduard13 eduard13 self-assigned this Feb 19, 2021
@eduard13 eduard13 self-requested a review February 19, 2021 12:01
@eduard13 eduard13 added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Feb 19, 2021
@eduard13
Copy link
Contributor

@magento run Database Compare, Functional Tests B2B, Functional Tests EE, Semantic Version Checker, Unit Tests

@eduard13
Copy link
Contributor

@magento run Database Compare, Functional Tests B2B, Semantic Version Checker, Unit Tests

Copy link
Contributor

@eduard13 eduard13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Usik2203, could you please check what's reason of Unit Test failing?

@@ -395,7 +411,7 @@ public function getProductTypeName($id)
* @param string $value
* @return null|mixed
*/
public function getSourceOptionId($source, $value)
public function getSourceOptionId($source, string $value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Usik2203 lets revert this change.

Suggested change
public function getSourceOptionId($source, string $value)
public function getSourceOptionId($source, $value)

@eduard13
Copy link
Contributor

@magento run Magento Health Index

@eduard13
Copy link
Contributor

@magento run Functional Tests B2B

@magento-engcom-team
Copy link
Contributor

Hi @eduard13, thank you for the review.
ENGCOM-8879 has been created to process this Pull Request

@Usik2203 Usik2203 changed the base branch from 2.5-develop to 2.4-develop April 13, 2021 15:09
@Usik2203 Usik2203 changed the base branch from 2.4-develop to 2.5-develop April 13, 2021 15:09
@Usik2203
Copy link
Contributor Author

Closed in favour of #32738

@Usik2203 Usik2203 closed this Apr 13, 2021
@m2-assistant
Copy link

m2-assistant bot commented Apr 13, 2021

Hi @Usik2203, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Component: Catalog Component: Checkout Component: Customer Component: Image Component: Quote Component: Ui Partner: Atwix Pull Request is created by partner Atwix partners-contribution Pull Request is created by Magento Partner Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Project: API Changes Release Line: 2.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants