-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Do you propose Bootstrap theme ? #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Bootstrap is a moving target. There are plenty of integrators and theme shops that will provide a Bootstrap-centric theme (and Foundation and TopCoat and all of the others). IMHO the Magento base theme should not require knowledge of those frameworks and should be a best-practices implementation of how to roll a theme from scratch. |
Maybe http://smacss.com/ instead? It suggests some great ideas and practices for building scalable css without being tied to a library or framework. A perfect starting point for a base theme IMHO |
Agree with @philwinkle. Frontend frameworks change much faster than Magento can keep pace. That's not a knock, it's a fact. If Magento 2 has a +5 year lifespan like Magento 1, then we're assuming something from today like Bootstrap will still be relevant and I don't think it will. The core frontend package should be just that — not a theme. There are plenty of examples in Magento 1, where templates in "base/default" were written a certain way so the Magento demo using "default/modern" looked nice. Implementations had to override these practices (annoyingly) and support those changes indefinitely (gratingly). Magento should have written those changes into a "default/x" package as a "proper theme" and kept "base/default" clean. I'm not saying that was obvious either. It was probably pretty impossible for Magento to know up-front what patterns implementors would need / evolve to use. But it would be a mistake today to bake those decisions into the core of Magento 2. |
@keniosor It's imperative that the Magento 2 "theme" facilitate a Bootstrap implementation... or Nüstrap, or whatever evolves in the next five years :-). If Magento, Inc. wants to provide a finished theme using this base, that's great, but theming assets & machinery should be built to facilitate customization. |
I agree with @benmarks and others here but I do think its important that there is an implementation which supports using today's offerings around front-end frameworks such as Bootstrap, Foundation, etc. One of the biggest problems in Magento right now is getting skilled staff, the more that public frameworks can be integrated the more opportunity this provides to the startup companies, small agencies, developers who are in the Magento space or want to be. The percentage of the Magento development community that actually want to be able to customise down to the nth degree is actually pretty small IMO. This whole thing is a moving target, whatever is done will be out of date in 5 years, but Magento has to just put a stake in the ground, commit and then execute it. Else we are in danger of Magento 2 taking another 3 years to get out of the door. |
Thanks for commenting @wsakaren. I think your point that frontend frameworks make it easier for companies to staff is valid. My issue is that binding Bootstrap/Foundation/etc to Magento would prescribe so much that the entire frontend would need to be rewritten for their implementation to be useful. That would swamp the Magento 2 timeline, and entrench too much to any third-party. The reason frontend frameworks are good isn't solely because of the patterns, I think it's mainly because of the deep and robust documentation. This is what helps new developers become effective with the system quickly. Magento has tons of frontend patterns, but zero frontend documentation. What Magento really needs to do is document how/why/where its patterns are implemented in the core, so new developers don't have to work through multiple projects just to notice they exist. That's why it's hard to find qualified frontend developers. You can always cherry-pick specific components from third-party frameworks (they're designed for that) but replacing the frontend architecture with Bootstrap is a lot more involved than documenting the long-standing Magento patterns (which are quite good—albeit limited—if you see them). |
...and the deviations from those patterns... |
Hi All, this we decided to go with Magento UI library, it is documented here https://github.com/magento/magento2/tree/master/lib/web/css/docs |
[MX][Virtual Team] Public GitHub Issues, Bug Fixes
Fixed issues: - MAGETWO-57039: Update gallery entry via API doesn't work - for 2.1 - MAGETWO-54808: Unable to mass-edit a product attribute for a configurable product
Do you propose Bootstrap theme ?.If it isn' t the case, can you include it in the next release ?.
Thanks
The text was updated successfully, but these errors were encountered: