use of registry in Magento\Tax\Helper\Data

[fooman]

This method here

https://github.com/magento/magento2/blob/master/app/code/Magento/Tax/Helper/Data.php#L937

should be refactored to work without the registry.

[verklov]

Hello fooman,
Thank you for reporting this issue!
Out team will investigate it and we will respond once we have the results.

[verklov]

Hello fooman,
Why do you think we should not use registry in this case? It is unclear for us at this point which problem will be solved by the suggested refactoring.

[fooman]

Using the registry in this way will make it very hard (and surprising) for any one else to use the method

public function getShippingTax($source)
{
    if ($this->_coreRegistry->registry('current_invoice')) {
        $current = $this->_coreRegistry->registry('current_invoice');
    } elseif ($this->_coreRegistry->registry('current_creditmemo')) {
        $current = $this->_coreRegistry->registry('current_creditmemo');
    } else {
        $current = $source;
    }

    $taxClassAmount = array();
    if ($current && $source) {
        if ($current->getShippingTaxAmount() != 0 && $current->getBaseShippingTaxAmount() != 0) {

For example let's say I want to add to the invoice confirmation email the following

Order Shipping Tax: XXX of which has been invoiced in this invoice: XXX

You would think that using getShippingTax($order) and getShippingTax($invoice) should work. However due to the registry use there is no way to get $current to be anything but the current_invoice. When you have multiple invoices per order the results would be incorrect.

[benmarks]

👍

[wshqq]

Thumbs up. The function getShippingTax and getCalculatedTaxes didn't need the registry. We need ths function to get calculated Taxes for invoice or creditmemo, so we should pass those objects and not the order. From invoice and creditmemo you can call getOrder(). This function was added with Magento 1.6 and we have to register invoices and creditmemos every time, we want to use this function. This doesn't make sense.
This function is important for 3rd party extension dealing with invoices and creditmemos.

[verklov]

@fooman, the team resolved the issue that you reported. The code with the fix is now available in the repository. Thank you again for your contribution! We are closing this ticket now.