Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recently viewed products sidebar issue #659

Closed
tzyganu opened this issue Sep 10, 2014 · 2 comments
Closed

Recently viewed products sidebar issue #659

tzyganu opened this issue Sep 10, 2014 · 2 comments
Assignees
@verklov

Comments

@tzyganu
Copy link
Contributor

tzyganu commented Sep 10, 2014

If I haven't viewed any products in the current session, the recently viewed products block on the sidebar still appears but it only shows the title Recently Viewed Products.
The problem originates from app/code/Magento/Reports/view/frontend/templates/product_viewed.phtml

This is the condition that checks if the block should appear

<?php if ($_products = $this->getRecentlyViewedProducts()): ?>

But $this->getRecentlyViewedProducts() always returns an instance of Magento\Reports\Model\Resource\Product\Index\Viewed\Collection that evaluates to true even if there are no items in the collection. A getSize or count restriction should solve this (but you already know that).
@verklov
Copy link
Contributor

verklov commented Sep 10, 2014

@tzyganu, we created a ticket for the team to investigate on this. Thanks for this bug report!

@verklov verklov self-assigned this Sep 10, 2014
magento-team added a commit that referenced this issue Sep 26, 2014
@magento-team
0.1.0-alpha97
873d38c 
* Various improvements:
   * Implemented a general way of using RSS module
   * Created a cron job in the Customer module for cleaning the customer_visitor table
   * Added a warning message to the Use HTTP Only option in the Admin panel
   * Implemented the Grid component in the Magento UI Library
   * Reimplemented the URL Rewrites functionality in the new UrlRedirect module
 * Framework improvements:
   * Added the ability to install Magento 2 using CLI
   * Aggregated Magento installation and upgrade into one tool
   * Refactored CustomerService REST WebApi to be more RESTful
   * Increased unit and integration test coverage
   * Moved page asset management to page configuration API, and eliminated the \Magento\Theme\Block\Html\Head block
   * Eliminated the Root, Html and Title blocks
 * Themes update:
   * Removed widgets from the default Magento installation
 * Fixed bugs:
   * Fixed an issue with wishlist creation for non-registered customer
   * Fixed an issue with Google Mapping where Condition did not show correct value
   * Fixed an issue  where there were too many notifications for admin user by default
   * Fixed a Daylight Savings Time calculation error
   * Fixed an issue where default cookie path and lifetime were not validated prior to saving
   * Fixed an issue where current admin password was not required for resetting admin password
   * Fixed an issue where custom customer attribute or customer address attribute was not accessible when custom_attribute is used as the attribute code
   * Fixed an issue where integration entity could not be deleted after being searched in grid
   * Fixed an issue where invalid parameter value was shown in SOAP
   * Fixed an issue where exception was thrown for Array to String conversion in SOAP
   * Fixed an issue where exception was thrown due to invalid argument supplied for foreach() statement in REST
   * Fixed an issue where admin tax notifications did not appear correctly in the System Messages dialog box
   * Fixed an issue where tax details were missing when viewing order in the Admin panel
   * Fixed an issue where styles for the storefront store selector were absent
   * Fixed an issue where customer got 404 page when switching store views on the product page of a product with different URL keys in different store views
   * Fixed an issue where the Add To Cart button in the MAP pop-up did not work for configurable and bundle products
   * Fixed an issue where for specifying options for configurable product was absent after adding a product from the MAP pop-up
   * Fixed an issue where a fatal error was thrown after selecting shipping method on PayPal Express Checkout
   * Fixed an issue with sending invoice email
   * Fixed an issue where integration tests failed with a fatal error
   * Fixed an issue where credit memo entry was not created after performing a refund for an order
   * Fixed an issue where categories layout for widgets did not work
   * Fixed an issue where opening a page restricted by ACL lead to blank page instead of the Access Denied page
   * Fixed an issue where a blank page was displayed instead of the using the Advanced Search result
   * Fixed an issue where the "Please wait" spinner was absent on Ajax requests for order creation in the Admin panel
   * Fixed an issue with the main navigation menu location on the page
 * Modularity:
   * Implemented the automatic applying of the MAP policy
 * Indexers:
   * Eliminated the old Magento_Index module
 * Search library
   * Added wildcards filter
   * Eliminated unused queries and filters
   * Added IN to Term filter
   * Moved the "value" attribute from <match> to <query> for the Match query
   * Refactored the usage of negation
   * Implemented Request Builder
 * CatalogSearch adapter
   * Pluginized adding attribute to search index
   * Merged base declaration with searchable attributes
 * Added the following Setup CLI tools in the setup folder
   * Deployment Configuration Tool
   * Schema Setup and Update Tool
   * DB Data Update Tool
   * Admin User Setup Tool
   * User Configuration Tool
   * Installation Tool
   * Update Tool
 * GitHub requests:
   * [#615] (#615) -- Use info as object in checkout_cart_update_items_before
   * [#659] (#659) -- Recently viewed products sidebar issue
   * [#660] (#660) -- RSS global setting
   * [#663] (#663) -- session.save_path not valid
   * [#445] (#445) -- use of registry in Magento\Tax\Helper\Data
   * [#646] (#646) -- Fixed flat category indexer bug
   * [#643] (#643) -- Configurable Products Performance
   * [#640] (#640) -- [Insight] Files should not be executable
   * [#667] (#667) -- Tiny improvement on render() method in Column/Renderer/Concat
   * [#288] (#288) -- Add Cell Phone to Customer Address Form
   * [#607] (#607) -- sitemap.xml filename is not variable
   * [#633] (#633) -- Fixed Typo ($_attribite -> $_attribute)
   * [#634] (#634) -- README.md contains broken link to X.commerce Agreement
   * [#569] (#569) -- ObjectManager's Factory should be replaceable depending on service
   * [#654] (#654) -- Demo notice overlapping
 * Functional tests:
   * Abandoned carts report
   * Adding products from wishlist to cart
   * Create invoice for offline payment methods
   * Delete products from shopping cart
   * Delete widget
   * Global search
   * Order count report
   * Order total report
@verklov
Copy link
Contributor

verklov commented Sep 26, 2014

@tzyganu, the team has fixed this issue. Please find the code with the fix in 0.1.0-alpha97. Thank you for contributing to Magento quality!

@verklov verklov closed this as completed Sep 26, 2014
okorshenko pushed a commit that referenced this issue Oct 21, 2015
Merge pull request #659 from magento-folks/merchant_beta
a2f610e 
[Merchant Beta][Folks]Bugfix
okorshenko pushed a commit that referenced this issue Dec 14, 2016
Merge pull request #659 from magento-fearless-kiwis/MAGETWO-61889-upg…
1df63f4 
…rade-tests

Fixed Issues:
 - MAGETWO-61889 Add debug events preset to UI Upgrade tests
 - MAGETWO-61927 UI Upgrade from 2.0.x to 2.0.11 Test Failure with Sample Data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verklov verklov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tzyganu @verklov