Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.1 email logo image function does not work #5352

Closed
Nerogee opened this issue Jun 29, 2016 · 73 comments
Closed

Magento 2.1 email logo image function does not work #5352

Nerogee opened this issue Jun 29, 2016 · 73 comments
Assignees
Labels
bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed

Comments

@Nerogee
Copy link

Nerogee commented Jun 29, 2016

Steps to reproduce

  1. Magento 2.1
  2. Upload Email logo in path Content -> Configuration -> Transactional Email -> Logo Image
  3. Save

Expected result

  1. New Email Logo should show in New Order (ALL) Emails

Actual result

  1. Default Magento Logo is used in email
  2. Customized logo does not show
  3. Logo Image URL Broken in preview under path Content -> Configuration -> Transactional Email -> Logo Image
@sevos1984
Copy link
Contributor

This issue was fixed in MAGETWO-53010 and delivered to develop branch

@wert2all wert2all added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Jun 30, 2016
@didineedthis
Copy link

how do i find the file to update? i just copied the missing image location and added the folder there? but i would like to fix the issue

@sevos1984
Copy link
Contributor

What file you mean? You can find the fix here 23103c0

@didineedthis
Copy link

Cheers sorted, Thanks for the link. appreciated :)
You said "This issue was fixed in MAGETWO-53010"

I didn't know how to find the fix "MAGETWO-53010" i still dont . i see lots of people stating this was fixed in MAGETWO-XXXX But i have no idea how to find it?

Regards

@sevos1984
Copy link
Contributor

When issue is closed link should be attached, but since this one is open you can search MAGETWO-XXXX in pull requests and then find attached commits in it.

@didineedthis
Copy link

Ok thanks for your help, appreciated.
Regards

@slavvka
Copy link
Member

slavvka commented Jul 4, 2016

@Nerogee the issue has been fixed and delivered to mainline. Please see 23103c0, 2f32aed and cb603ff

@TheFrankman
Copy link

What should we do about this in the mean time ? Abstract class and protected methods. This rules out a temporary preference and plugin. Anyone have a better idea than a symlink ?

@samc2810
Copy link

Hi there

this issue was supposed to be patched in the nearest release, but the 2.1.1 still has the issue and it was released yesterday. not cool

@skemar
Copy link

skemar commented Sep 7, 2016

Just to confirm what samc2810 wrote, the issue has not been fixed in 2.1.1.

@flnative
Copy link

Can someone guide me how to fix this? I have 2.1.1. Everyone is sending Luma logos in their emails? ARe there not that many people using 2.1? I don't get it. Why isn't this not considered a major issue?

@cuiyang000
Copy link

Can confirm the bug, dirty/temporary way to solve is:

  1. Upload the image
  2. Check the file path in preview box
  3. Copy that file to pub/media/email/logo/stores/1/ (1 can be other number, depending on the store id)
  4. Save the configuration

@nht48823
Copy link

nht48823 commented Oct 1, 2016

I have spend the entire day trying to get this to work without any success. I am on ver 2.1.1 brand new installation this functionality worked with previous version, I am confused to why mess with something that worked.
anyway - I upload the image in the backend since the upload doesnt actuly upload the file, I click to view the file path i see - pub/media/email/logo/stores/1/logo_email_2.png - I manually upload the file logo_email_2.png to the following directory.
I have also uploaded this same fie in - /vendor/magento/module-email/view/frontend/web

New order e-mail is still not showing the image (see attached). when i follow the link to the image from the email - I have the correct image it shows the image i uploaded.
noiamge

I have removed all the email logo images from the backend cleared all the cache left it as default luma logo and it shows up correctly for luma logo in the email....what i cannot figure out where is this Luma email logo coming from, when i click to find the path in the email, it takes me to my personal logo. i have cleared all the cache also the static folders about 100 times - what a nightmare. can some one help me with this

Thank you

@mrkhoa99
Copy link
Contributor

mrkhoa99 commented Oct 2, 2016

@nht48823 Seem that Google will don't show image without https. We should inspect the image link, and go to this image, if it exists, your logo image is correct.

@timbaker1991
Copy link

timbaker1991 commented Oct 13, 2016

Is anyone able to confirm if a fix for this has been included the new 2.1.2 release?

@slavvka
Copy link
Member

slavvka commented Oct 13, 2016

@timbaker1991, unfortunately no.

@mashb1t
Copy link
Member

mashb1t commented Oct 20, 2016

@timbaker1991 Well, it definitely had to be included in Release 2.1.2 ... Still waiting for the fix!

@Ubeo
Copy link

Ubeo commented Oct 25, 2016

It looks like it is still not repaired in 2.1.2

@Will-I4M
Copy link
Contributor

one quick and dirty way is to edit vendor/magento/module-email/view/frontend/email/header.html line 50, replace the {{xxx}} by the src of your image for example : https://www.example.com/pub/media/logo/stores/1/logo.png

@olafc100
Copy link

Is somebody still working on this because it is still not working for me. I am only sending out emails the Luma logo. How do others work around this?

thanks for any help

@teyou
Copy link

teyou commented Dec 1, 2016

confirmed still broken on 2.1.2

@duongquyet
Copy link

Hi,
I have same issue. Any new?

@andreaschiffo
Copy link

andreaschiffo commented Dec 9, 2016

same problem here on 2.1.0, workin on Store View scope

what i notice is
logo is uploaded into pub/media/tmp/design/file/
logo is saved into pub/media/logo/stores/1/
logo is read -in admin backend- from pub/media/email/logo/stores/1/
logo is read -in email- from
pub/static/frontend/Vendor/Module/en_US/Magento_Email/
(default Magento logo is used, because custom logo is not found)

solved copying the logo into the manually created folder pub/media/email/logo/stores/1/

so the problem is when you save the logo, and it is uploaded to the wrong directory

didn't try on 2.1.2, but will do and report soon

@andidhouse
Copy link

@hostep - no i did not read that! There are about 30 bugs reported at GitHub according to the same email logo topic and you simply can not read all of them.

But to be honest i really miss timelines and quick fixes of the magento team. This bug is now over a year reported and not solved. Now its gonna be solved "maybe" in 2.1.7 or 8... ok when should that be and what is "maybe"?

I think too many people spent too many time on reporting and fixing bugs for m2. The way more simple solution in my opinion would be to introduce a system with not so many bugs ;-).

But thanks very much for the info also it is not really of value for us users with no timeline at all.

@michaeldyl520
Copy link

confirmed still broken on magento2 2.1.6

@ghost
Copy link

ghost commented Jul 3, 2017

Same on 2.1.7. Anyway, just copied the folder to the right place.

@congaframe
Copy link

guys, it will be fixed .. one day, yes, either in 2.1.xx , or m3 or m4 :)
I found a dozen of 1-year-old bugs that have been fixed, but they are still in ..Development branch , people never released them
Very bad management

@timbaker1991
Copy link

timbaker1991 commented Jul 11, 2017 via email

@smdevdk
Copy link

smdevdk commented Jul 11, 2017

Priorities: http://devdocs.magento.com/guides/v2.1/release-notes/ReleaseNotes2.1.5CE.html

magedev

@blizam
Copy link

blizam commented Jul 28, 2017

follow

lutpiero added a commit to lutpiero/Magento-2-Overrider that referenced this issue Jul 31, 2017
-bug fix magento/magento2#5352

Signed-off-by: Yanuar Lutfi <lutpiero@gmail.com>
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-69062

@magento-team magento-team added 2.1.x Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report labels Jul 31, 2017
@commalex
Copy link

Still having this issue running a live 2.1.7 multi-store. Hope it gets fixed soon. Hate messing with code.

@orlangur
Copy link
Contributor

@commalex try upgrading to 2.1.8 which was released yesterday (see http://devdocs.magento.com/guides/v2.1/release-notes/ReleaseNotes2.1.8EE.html#general).

@apexdivision
Copy link

Still having the issue after upgrading to 2.1.8
The image now shows fine in admin panel, however mail still shows default Magento logo, not the custom logo.
The custom theme we are using does not overwrite the email templates.
Anyone else facing similar issue? Any advise?
Thank you.

@carb0nknight
Copy link

Is this really still an issue after being reported over a year ago? Bug still appears to be present in both 2.1.7 and 2.1.8

@orlangur
Copy link
Contributor

orlangur commented Sep 8, 2017

@apexdivision @carb0nknight issue seems to be fixed according to comments in 23103c0#commitcomment-23995349. It is always better to report a new issue describing all necessary details referring to a closed one than comment on a closed issue.

@Anees-Ahmad
Copy link

I have a quick solution to do this and it will done by changing core files.Open magento vendor/magento/module_email/view/frontend/email header.phtml file.In this file change the img src by adding your logo img hardcode around line 50.

@magento-engcom-team magento-engcom-team added the Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed label Oct 30, 2017
@carb0nknight
Copy link

@Anees-Ahmad That's not a solution, it's a workaround, one that will be required to be repeated anytime you pull changes to the core files or update.

@sumeetmobiwebtech
Copy link

This Issue is also present in magento 2.3 version

email_custom

@orlangur orlangur reopened this May 20, 2019
@ghost ghost removed the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label May 20, 2019
@ghost ghost self-assigned this May 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented May 21, 2019

Hi @surbhi-ranosys. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.
    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

@engcom-Charlie engcom-Charlie self-assigned this Aug 5, 2019
@m2-assistant
Copy link

m2-assistant bot commented Aug 5, 2019

Hi @engcom-Charlie. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Charlie
Copy link
Contributor

Hello @Nerogee
I can't reproduce this issue on fresh Magento 2.3-develop.
So i close it.
Thank for your report!

magento-engcom-team pushed a commit that referenced this issue Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed
Projects
None yet
Development

No branches or pull requests