-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magento 2.1 email logo image function does not work #5352
Comments
This issue was fixed in MAGETWO-53010 and delivered to develop branch |
how do i find the file to update? i just copied the missing image location and added the folder there? but i would like to fix the issue |
What file you mean? You can find the fix here 23103c0 |
Cheers sorted, Thanks for the link. appreciated :) I didn't know how to find the fix "MAGETWO-53010" i still dont . i see lots of people stating this was fixed in MAGETWO-XXXX But i have no idea how to find it? Regards |
When issue is closed link should be attached, but since this one is open you can search MAGETWO-XXXX in pull requests and then find attached commits in it. |
Ok thanks for your help, appreciated. |
What should we do about this in the mean time ? Abstract class and protected methods. This rules out a temporary preference and plugin. Anyone have a better idea than a symlink ? |
Hi there this issue was supposed to be patched in the nearest release, but the 2.1.1 still has the issue and it was released yesterday. not cool |
Just to confirm what samc2810 wrote, the issue has not been fixed in 2.1.1. |
Can someone guide me how to fix this? I have 2.1.1. Everyone is sending Luma logos in their emails? ARe there not that many people using 2.1? I don't get it. Why isn't this not considered a major issue? |
Can confirm the bug, dirty/temporary way to solve is:
|
@nht48823 Seem that Google will don't show image without |
Is anyone able to confirm if a fix for this has been included the new 2.1.2 release? |
@timbaker1991, unfortunately no. |
@timbaker1991 Well, it definitely had to be included in Release 2.1.2 ... Still waiting for the fix! |
It looks like it is still not repaired in 2.1.2 |
one quick and dirty way is to edit vendor/magento/module-email/view/frontend/email/header.html line 50, replace the {{xxx}} by the src of your image for example : https://www.example.com/pub/media/logo/stores/1/logo.png |
Is somebody still working on this because it is still not working for me. I am only sending out emails the Luma logo. How do others work around this? thanks for any help |
confirmed still broken on 2.1.2 |
Hi, |
same problem here on 2.1.0, workin on Store View scope what i notice is solved copying the logo into the manually created folder pub/media/email/logo/stores/1/ so the problem is when you save the logo, and it is uploaded to the wrong directory didn't try on 2.1.2, but will do and report soon |
@hostep - no i did not read that! There are about 30 bugs reported at GitHub according to the same email logo topic and you simply can not read all of them. But to be honest i really miss timelines and quick fixes of the magento team. This bug is now over a year reported and not solved. Now its gonna be solved "maybe" in 2.1.7 or 8... ok when should that be and what is "maybe"? I think too many people spent too many time on reporting and fixing bugs for m2. The way more simple solution in my opinion would be to introduce a system with not so many bugs ;-). But thanks very much for the info also it is not really of value for us users with no timeline at all. |
confirmed still broken on magento2 2.1.6 |
Same on 2.1.7. Anyway, just copied the folder to the right place. |
guys, it will be fixed .. one day, yes, either in 2.1.xx , or m3 or m4 :) |
I am watching several issues which have a very similar theme... just have to hope that they are working on a mega release at some point
… On 11 Jul 2017, at 22:14, congaframe ***@***.***> wrote:
guys, it will be fixed .. one day, yes, either in 2.1.xx , or m3 or m4 :)
I found a dozen of 1-year-old bugs that have been fixed, but they are still in ..Development branch , people never released them
Very bad management
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
follow |
-bug fix magento/magento2#5352 Signed-off-by: Yanuar Lutfi <lutpiero@gmail.com>
Internal ticket to track issue progress: MAGETWO-69062 |
Still having this issue running a live 2.1.7 multi-store. Hope it gets fixed soon. Hate messing with code. |
@commalex try upgrading to 2.1.8 which was released yesterday (see http://devdocs.magento.com/guides/v2.1/release-notes/ReleaseNotes2.1.8EE.html#general). |
Still having the issue after upgrading to 2.1.8 |
Is this really still an issue after being reported over a year ago? Bug still appears to be present in both 2.1.7 and 2.1.8 |
@apexdivision @carb0nknight issue seems to be fixed according to comments in 23103c0#commitcomment-23995349. It is always better to report a new issue describing all necessary details referring to a closed one than comment on a closed issue. |
I have a quick solution to do this and it will done by changing core files.Open magento vendor/magento/module_email/view/frontend/email header.phtml file.In this file change the img src by adding your logo img hardcode around line 50. |
@Anees-Ahmad That's not a solution, it's a workaround, one that will be required to be repeated anytime you pull changes to the core files or update. |
Hi @surbhi-ranosys. Thank you for working on this issue.
|
Hi @engcom-Charlie. Thank you for working on this issue.
|
Hello @Nerogee |
[TSG-Commerce] Tests for 2.4 (pr8)
Steps to reproduce
Expected result
Actual result
The text was updated successfully, but these errors were encountered: