Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newsletter subscription #5439

Closed
ednacool opened this issue Jul 4, 2016 · 13 comments
Closed

Newsletter subscription #5439

ednacool opened this issue Jul 4, 2016 · 13 comments
Assignees
Labels
bug report Component: Customer Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release

Comments

@ednacool
Copy link

ednacool commented Jul 4, 2016

Preconditions

  1. Magento 2.1

Steps to reproduce

  1. Create customer
  2. Subscribe customer to a Newsletter
  3. Verify that customer is subscribed to the newsletter and received email notification about subscription.
  4. Subscribe same customer to the same email again.

Expected result

  1. Customer does not receive another email on subscribing to newsletter

Actual result

1 Customer keeps receiving emails on every newsletter subscription.

Description

No onscreen confirmation of sign up. No error message when trying to subscribe an existing subscriber

Getting message on subscribing newsletter as well as e-mail.

You have been successfully subscribed to our newsletter.

It should generate an error if i am subscribing with the same email address again and again but it won't

@antboiko
Copy link

antboiko commented Jul 4, 2016

Hi @ednacool , please provide detailed steps to reproduce the issue in an appropriate format with Expected and Actual results. What Magento version are you running?

Best,
Anton.

@orlangur
Copy link
Contributor

orlangur commented Jul 4, 2016

@antboiko provided steps are sufficient. At least I don't see any obscurity.

No error message when trying to subscribe an existing subscriber

This is correct behavior. Same as for registering or password recovery - system should not reveal excessive information about emails to avoid their grabbing for spam or something.

Getting message on subscribing newsletter as well as e-mail.

And this does not seem OK. Basically, you should not receive more than one email until you confirm subscription I believe. So that you cannot bother somebody with tons of same messages by just having his email.

@antboiko
Copy link

antboiko commented Jul 6, 2016

Hi @ednacool , thanks for reporting. We've created internal ticket MAGETWO-55106 to investigate this.

@antboiko antboiko added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development MX bug report and removed Progress: needs update labels Jul 6, 2016
@hezide
Copy link

hezide commented Oct 18, 2016

same issue here, magento CE 2.1.2.

@PGLDK
Copy link

PGLDK commented Mar 10, 2017

same 2.1.4

@magento-engcom-team magento-engcom-team added Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development bug report Component: Customer Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 11, 2017
@lhsatch
Copy link

lhsatch commented Sep 15, 2017

Just after line 429 add:
$checkGuest = $this->loadByEmail($email); if($checkGuest->getSubscriberId()){ throw new \Magento\Framework\Exception\LocalizedException( __('This email address has already subscribed.') ); }

@magento-engcom-team magento-engcom-team added Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed Issue: Format is not valid Gate 1 Failed. Automatic verification of issue format is failed labels Sep 22, 2017
@magento-engcom-team
Copy link
Contributor

@ednacool, thank you for your report.
We've created internal ticket(s) MAGETWO-78293 to track progress on the issue.

@magento-engcom-team magento-engcom-team added 2.1.x Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release labels Sep 25, 2017
@osrecio
Copy link
Member

osrecio commented Oct 4, 2017

@okorshenko Can you assign me this issue?

@okorshenko
Copy link
Contributor

#SQUASHTOBERFEST

@osrecio
Copy link
Member

osrecio commented Oct 9, 2017

Created PR for 2.1 and 2.2

@okorshenko
Copy link
Contributor

The issue has been fixed in 2.2-develop branch

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-81326

@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-82942

magento-engcom-team pushed a commit that referenced this issue Mar 22, 2020
Reverted issues:
- ECP-261 Offload Catalog Image Resizing from Magento
- ECP-262 Offload Catalog Image Watermarking from Magento
- ECP-263 Deprecate Rotation Support in Magento
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Customer Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release
Projects
None yet
Development

No branches or pull requests