Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send email to subscribers only when are new #11604

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Send email to subscribers only when are new #11604

merged 1 commit into from
Oct 30, 2017

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Oct 20, 2017

Only send email/confirmation email of subscription to newsletter only when subscriber is new in newsletter

Description

Check if is necessary send email to a customer that is subscribed to newsletter. If this customer was subscribed previously not necessary send email.

Fixed Issues (if relevant)

  1. Newsletter subscription #5439: Newsletter subscription

Manual testing scenarios

  1. Subscribe an email not subscribed previously (e.g: test@test.com)
  2. this email will receive a confirmation email of subscription
  3. Subscribe the same email (test@test.com)
  4. this email NOT will recieve a confirmation email of subscription

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko added this to the October 2017 milestone Oct 27, 2017
@magento-team magento-team merged commit 38d5edf into magento:2.3-develop Oct 30, 2017
magento-team pushed a commit that referenced this pull request Oct 30, 2017
@ishakhsuvarov
MAGETWO-82942: Send email to subscribers only when are new #11604
e52b762
magento-team pushed a commit that referenced this pull request Oct 30, 2017
@ishakhsuvarov
Merge pull request #1639 from magento-engcom/develop-prs
7ec352a 
[EngCom] Public Pull Requests - develop
 - MAGETWO-82942: Send email to subscribers only when are new #11604
 - MAGETWO-82752: Fixes translations by re-running the loadData for its correct locale #10913
 - MAGETWO-82460: Fix AcountManagementTest unit test fail randomly #11605
 - MAGETWO-82070: Update knockout #11269
@osrecio osrecio deleted the PR#NewsletterEmailSend-dev branch October 30, 2017 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
bug report Component: Customer Progress: accept Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release
Projects
None yet
Milestone
October 2017
Development

Successfully merging this pull request may close these issues.
3 participants
@osrecio @magento-team @okorshenko