Fixes translations by re-running the loadData for its correct locale

[wiardvanrij]

Description

When running setup:static-content:deploy with multiple languages specified, it will generate a js-translation.json. Even if the locale is set properly for each language, it will translate just based on
$this->translator->getData(); in Magento\Framework\Phrase\Renderer

In other words it will use the data retrieved from the loadData function in the Framework/Translation.php
This uses a constructor which sets the locale; \Magento\Framework\Locale\ResolverInterface $locale and obviously followed by $this->_locale = $locale;

The problem here is that the loadData only gets ran once on init. It will keep using this for every other locale as 'base'. Therefore a potential locale change should also re-run the loadData.

By forcing a "rebuild" of the loadData with the correct locale, we will parse the data with the correct translations.

As extra because we are forcing the locale & rebuild we can remove the FallbackContext filler for the locale as we are setting it anyways.

Fixed Issues

1. [2.2.0-RC2.2] Static content deploy with multiple locales: js-translation.json files are the same #10673: [2.2.0-RC2.2] Static content deploy with multiple locales: js-translation.json files are the same

Manual testing scenarios

1 Run php bin/magento setup:static-content:deploy -f -t Magento/luma nl_NL fr_FR
2 Run diff -rwq pub/static/frontend/Magento/luma/nl_NL/ pub/static/frontend/Magento/luma/fr_FR/
3 js-translation.json are now different from each other with the correct language translations

[magento-cicd2]

All committers have signed the CLA.

[wiardvanrij]

I do not know why the unit test gives me Call to a member function loadData() on null. It makes no sense.. Anyone got an idea?

[vrann]

@douweegbertje: This class \Magento\Translation\Test\Unit\Model\Json\PreProcessorTest creates a mock of TranslateInterface so it can not possibly have the right logic for setLocale which should return proper object:

 $this->translateMock = $this->getMockForAbstractClass(\Magento\Framework\TranslateInterface::class);

Please create the mock for setLocale method.