Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate attributes on system.xml files #650

Closed
tzyganu opened this issue Sep 4, 2014 · 3 comments
Closed

Translate attributes on system.xml files #650

tzyganu opened this issue Sep 4, 2014 · 3 comments
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@tzyganu
Copy link
Contributor

tzyganu commented Sep 4, 2014

It seams to me that the translate attribute on elements inside the system.xml files is useless and it should be removed.
From what I found in the code, the labels and comments are translated anyway in Magento\Backend\Model\Config\Structure\AbstractElement.
I also removed for test purposes the translate attribute from an element, change the translation for that text from the i18n folder and in the backend I got the translated version of the text.
@verklov verklov self-assigned this Sep 9, 2014
@verklov
Copy link
Contributor

verklov commented Sep 9, 2014

@tzyganu, thanks for this ticket! I will consult the architect and get back to you once we have a response.

@maksek maksek added the PROD label Jan 8, 2015
@vpelipenko
Copy link
Contributor

Internal ticket: MAGETWO-28204

@ilol ilol added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Mar 18, 2015
@piotrekkaminski
Copy link
Contributor

We will be using an external tool to work on translations. We might then later push them to git or keep separate - not decided yet. Look for announcement soon.

okorshenko pushed a commit that referenced this issue Dec 14, 2016
Merge pull request #650 from magento-fearless-kiwis/MAGETWO-61850-2.1…
924ea3f 
…-upgrade-test

MAGETWO-61850: UI Upgrade Test
magento-engcom-team added a commit to okorshenko/magento2 that referenced this issue May 10, 2019
@magento-engcom-team
ENGCOM-5092: GraphQl-535: provided catalog configs magento#650
ff754e8 
 - Merge Pull Request magento/graphql-ce#650 from magento/graphql-ce:graphQL-535-provide-catalog-cofigs-for-pwa
 - Merged commits:
   1. 9d240e3
   2. 8f36cf2
   3. 9f2f5b6
magento-engcom-team pushed a commit to okorshenko/magento2 that referenced this issue May 10, 2019
@naydav
ENGCOM-5092: GraphQl-535: provided catalog configs magento#650
42f5c82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@maksek @piotrekkaminski @tzyganu @verklov @vpelipenko @ilol