Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded region definitions from the /checkout page. #6997

Closed
pynej opened this issue Oct 13, 2016 · 6 comments
Closed

Remove unneeded region definitions from the /checkout page. #6997

pynej opened this issue Oct 13, 2016 · 6 comments
Labels
bug report Component: Checkout Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development

Comments

@pynej
Copy link

pynej commented Oct 13, 2016

Preconditions

  1. Magento 2.1.1
  2. PHP 5.6
  3. Apache

Steps to reproduce

  1. In admin go to Store > Configuration > General > Allowed Countries change this list to some limited set. (We selected only United States for example.)
  2. Clear all Magento caches.
  3. Go to the Checkout page

Expected result

  1. Template/JSON code embedded in page should not have region_id definitions for all the disabled regions.

Actual result

  1. There is still 320KB of region definitions loaded on every /checkout request for all the regions we have disabled. This is a major killer of performance on the checkout page as it has to download this data every time, wont be cached, and all the non-us region data in this case will never be used as we configured the site to only allow the us region.
@SerhiyShkolyarenko SerhiyShkolyarenko self-assigned this Oct 17, 2016
@SerhiyShkolyarenko SerhiyShkolyarenko added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Oct 17, 2016
@SerhiyShkolyarenko
Copy link
Contributor

@pynej thank you for reporting! We created internal issue MAGETWO-59796, but additional investigation is necessary if the fix could be backward compatible.

@pynej
Copy link
Author

pynej commented Oct 17, 2016

As an aside, we were sort of able to work around this issue by correctly configuring gzip compression on php files served under SSL. This is really a workaround as the file is still large and the data still hd to be decompressed and processed unnecessarily.

@adragus-inviqa
Copy link
Contributor

adragus-inviqa commented Oct 24, 2016

Maybe related to this "feature request" - #4217 ?

It was moved to the forums, as I clearly wasn't serious about the problem. The trollface didn't help my cause. I think they'll move yours to the forums, too, @pynej. Clearly not a bug.

@SerhiyShkolyarenko
Copy link
Contributor

MAGETWO-40098 implies another approach and more changes, so it's a story in terms of scrum.

mmansoor-magento pushed a commit that referenced this issue Nov 23, 2016
…, js scripts for unused payment & shipping methods #6997 #4868
@SerhiyShkolyarenko
Copy link
Contributor

We are closing the issue as MAGETWO-59685 fix is delivered to the develop branch. Thank you!

hostep added a commit to hostep/magento2 that referenced this issue Apr 24, 2017
…due to pulling in JSON config, remove unneeded region definitions from the checkout page. magento#6997 magento#4868
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-67725

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Component: Checkout Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development
Projects
None yet
Development

No branches or pull requests

5 participants