-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of MAGETWO-59685 for Magento 2.1 - Checkout pages very slow … #9364
Backport of MAGETWO-59685 for Magento 2.1 - Checkout pages very slow … #9364
Conversation
@@ -0,0 +1,146 @@ | |||
<?php | |||
/** | |||
* Copyright © 2016 Magento. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update copyright like in current 2.1-develop.
@@ -0,0 +1,114 @@ | |||
<?php | |||
/** | |||
* Copyright © 2016 Magento. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same problem with copyright.
…due to pulling in JSON config, remove unneeded region definitions from the checkout page. magento#6997 magento#4868
d0cd541
to
ee06028
Compare
@omiroshnichenko: I just amended the commit with the changed copyright header, and force pushed it. |
[EngCom] Public Pull Requests - 2.1 - MAGETWO-67753: Fix a bug resulting in incorrect offsets with dynamic row drag-n-drop functionality #9376 - MAGETWO-67725: Backport of MAGETWO-59685 for Magento 2.1 - Checkout pages very slow #9364 - MAGETWO-67724: Backport of MAGETWO-60351 for Magento 2.1 - Unnecessary disabled payment methods #9365
@hostep thank you for your contribution. Your Pull Request has been successfully merged |
…due to pulling in JSON config, remove unneeded region definitions from the checkout page. #6997 #4868
Description
This is a backport of issue MAGETWO-59685 for Magento 2.1
Fixed Issues (if relevant)
Reference to commit on the develop branch: 6a5ece2
Discussion
Together with the backport of MAGETWO-60351, this significantly speeds up the checkout process, even up to multiple seconds. This is due to the json data structure being outputted on the checkout containing way too many elements then necessary, which makes the client side processing of this json take a very long time (sometimes up to 10 seconds). In a concrete example of one of our webshops, this reduced the json structure from 175867 lines to 4003 lines.
MAGETWO-59685 in particular fixes not outputting country and region data for countries to which the webshop isn't selling.