Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug resulting in incorrect offsets with dynamic row drag-n-drop functionality #9376

Merged
merged 1 commit into from
Apr 27, 2017

Conversation

navarr
Copy link
Member

@navarr navarr commented Apr 24, 2017

Backport of PR #7161

Preconditions

  1. Chrome 54.0.2840.71 (Official Build) m (32-bit) on Windows 10
  2. Magento 2.1.2 Install
  3. Have a Simple Product with multiple Customizable Options

Steps to reproduce

  1. Attempt to drag the second item in the customizable options list to the first position

Expected Result

  1. The first position obtains a blue overline indicating that the option will be placed above it. The user is able to drag it up and over. (Video)

Actual Result

  1. The expected overline does not appear, and the object is unable to be moved above. (Video)

… functionality

Backport of PR #7161

### Preconditions
1. Chrome 54.0.2840.71 (Official Build) m (32-bit) on Windows 10
2. Magento 2.1.2 Install
3. Have a Simple Product with multiple Customizable Options

### Steps to reproduce
1. Attempt to drag the second item in the customizable options list to the first position

### Expected Result
1. The first position obtains a blue overline indicating that the option will be placed above it.  The user is able to drag it up and over. ([Video](https://gfycat.com/PleasantSmoggyElephantbeetle))

### Actual Result
1. The expected overline does not appear, and the object is unable to be moved above.  ([Video](https://gfycat.com/SpicyCavernousAmericantoad))
@ishakhsuvarov ishakhsuvarov self-assigned this Apr 24, 2017
@ishakhsuvarov ishakhsuvarov added this to the April 2017 milestone Apr 24, 2017
@magento-team magento-team merged commit 1a48d12 into magento:2.1-develop Apr 27, 2017
magento-team pushed a commit that referenced this pull request Apr 27, 2017
magento-team pushed a commit that referenced this pull request Apr 27, 2017
[EngCom] Public Pull Requests - 2.1
 - MAGETWO-67753: Fix a bug resulting in incorrect offsets with dynamic row drag-n-drop functionality #9376
 - MAGETWO-67725: Backport of MAGETWO-59685 for Magento 2.1 - Checkout pages very slow #9364
 - MAGETWO-67724: Backport of MAGETWO-60351 for Magento 2.1 - Unnecessary disabled payment methods #9365
@navarr navarr deleted the patch-3 branch April 27, 2017 14:58
@magento-team
Copy link
Contributor

@navarr thank you for your contribution to Magento 2 project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants