Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug resulting in incorrect offsets with dynamic row drag-n-drop functionality #7161

Merged
merged 1 commit into from
Mar 25, 2017
Merged

Fix a bug resulting in incorrect offsets with dynamic row drag-n-drop functionality #7161

merged 1 commit into from
Mar 25, 2017

Conversation

navarr
Copy link
Member

@navarr navarr commented Oct 24, 2016 •
edited by ishakhsuvarov
Loading

Preconditions

  1. Chrome 54.0.2840.71 (Official Build) m (32-bit) on Windows 10
  2. Magento 2.1.2 Install
  3. Have a Simple Product with multiple Customizable Options

Steps to reproduce

  1. Attempt to drag the second item in the customizable options list to the first position

Expected Result

  1. The first position obtains a blue overline indicating that the option will be placed above it. The user is able to drag it up and over. (Video)

Actual Result

  1. The expected overline does not appear, and the object is unable to be moved above. (Video)

@navarr
Fix a bug resulting in incorrect offsets with dynamic rows
2a9fa0e 
.find() will find the first <thead> in the tree underneath the table - including child tables.  .children() will, instead, locate the <thead> of our table.  .children() is what we want, and using .find() has caused issues with drag and drop functionality in the backend.
@vil11
Copy link

vil11 commented Nov 3, 2016

Hi. Thanks for reporting the issue. Internal ticket MAGETWO-55286.

@MomotenkoNatalia MomotenkoNatalia added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Nov 3, 2016
@ishakhsuvarov ishakhsuvarov self-assigned this Mar 23, 2017
@ishakhsuvarov ishakhsuvarov added this to the March 2017 milestone Mar 23, 2017
@magento-team magento-team merged commit 2a9fa0e into magento:develop Mar 25, 2017
magento-team pushed a commit that referenced this pull request Mar 25, 2017
@vrann
MAGETWO-66640: Fix a bug resulting in incorrect offsets with dynamic …
c2c4f9d 
…row drag-n-drop functionality #7161
@vrann
Copy link
Contributor

vrann commented Mar 25, 2017

@navarr Thank you for the contribution!

@navarr navarr deleted the patch-7 branch March 25, 2017 23:02
@navarr navarr mentioned this pull request Apr 24, 2017
Merged
magento-engcom-team pushed a commit that referenced this pull request Nov 4, 2021
@avattam06
Merge pull request #7161 from magento-arcticfoxes/B2B-2022
fa1824e 
B2B-2022 :[AWS S3] [Integration Tests]: Investigate Test Failures in Catalog module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@ishakhsuvarov ishakhsuvarov

Labels
Area: Frontend Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Progress: accept
Projects
None yet
Milestone
March 2017
Development

Successfully merging this pull request may close these issues.
8 participants
@navarr @vil11 @vrann @VladimirZaets @magento-team @vasiliyseleznev @ishakhsuvarov @MomotenkoNatalia