Filesystem Https driver does not work with https:// links #720

mszterlingfsite · 2014-10-31T20:45:04Z

If you specify link as https://domain.com/path/to/file.zip
Magento\Framework\Filesystem\Driver\Https which extends Magento\Framework\Filesystem\Driver\Http
will not create the stream correctly

https://github.com/magento/magento2/blob/master/lib/internal/Magento/Framework/Filesystem/Driver/Http.php
in fileOpen() method $port will always be 80

$parse = parse_url('https://domain.com/path/to/file.zip');
var_dump($parse);

returns

array(3) {
  ["scheme"]=>
  string(5) "https"
  ["host"]=>
  string(10) "domain.com"
  ["path"]=>
  string(17) "/path/to/file.zip"
}

so in above case @fsockopen($hostname, $port, $errorNumber, $errorMessage); will have incorrect hostname and port

For SSL $hostname should be ssl://domain.com and $port should be 443

The text was updated successfully, but these errors were encountered:

aohorodnyk · 2014-11-01T22:12:57Z

Hello,

I have reproduced bug from your issue, and I think you are right, it's important bug.

I created pull request #722 with fixes about your issue.

Thanks, Anton

* Various improvements: * Refactored Service Layer of the Magento_Tax Module * Stabilized functional tests for the Backend module * Stabilized functional tests for the CatalogRule module * Stabilized functional tests for the Checkout module * Stabilized functional tests for the CurrencySymbol module * Stabilized functional tests for the Shipping module * Stabilized functional tests for the Tax module * Stabilized functional tests for the User module * Added Readme.md files to the following modules: * Magento\RequireJs * Magento\Ui * Fixed bugs: * Fixed an issue where product image assignment to a store view was not considered when displaying a product * Fixed shipping address area blinking when billing address is filled during checkout with a virtual product * Fixed an issue where filter_store.html was not found * Fixed an issue where the customer account access menu did not expand on the storefront * Fixed an issue where CMS blocks did not open when clicking from a grid * Fixed an issue where the Create Product page was completely blocked after closing the New Attribute pop-up * Fixed an issue where Stock Status was disabled for Bundle and Grouped products * Fixed an issue where a product could not be saved without filling a not required bundle option * Fixed broken "per page" selectors on the Customer's account pages * Fixed the wrong behavior of JS loaders on the storefront pages * Fixed Shopping cart price rule form validation * Fixed an issue where the 'Please wait' spinner persisted when creating a customer custom attribute with existing code * Fixed a Google Chrome specific issue where subcategories were not displayed correctly on the first hover for category item * Fixed an issue where the 'Please wait' spinner did not disappear when creating customer with invalid email * Fixed an issue where the Username field auto-focus on admin login page revealed password in case of fast typing * Fixed an issue where Bundle Product original Price was not displayed in case of discount * Fixed wrong discount calculation for bundle options * Fixed an issue where wrong discount and total amounts were displayed on the order creation page when reordering an order with a bundle product in the Admin panel * Fixed an issue where admin tax notifications did not appear/disappear unless cache was flushed or disabled * Fixed an issue where catalog price and shopping cart price did not match when display currency was different from the base currency * Fixed an issue where Tax classes did not allow 'None' as a valid 'product tax class' * Fixed an issue where token-based authentication did not work if compilation was enabled * Fixed the sample code in index.php illustrating multi websites set up * Fixed commands in Setup CLI to match the ones displayed in help * Fixed an issue where searching by a part of a product name in Advanced Search did not give correct results * Fixed an issue where 404 page is displayed after Search Term mass deletion * Fixed an issue where Popular Search Terms were not displayed on the storefront * Fixed an issue where it was impossible to add Gift Message during one page checkout * Fixed an issue where the optional Postal code setting did not work correctly * Fixed an issue where product price details were missing in summary block in the shopping cart when the Back to shopping cart link was clicked on multishipping page * Fixed an issue where the 404 error page was displayed instead of the Index Management page after saving mass update * Fixed an issue where the "Out of Stock" message was not displayed for a bundle product when there was not enough of one of the associated products in stock * Fixed an issue with the Newsletters Report page in the Admin panel * Fixed an issue where Catalog price rule was not applying correct rates on specific products * Fixed an issue where a fatal error was thrown after clicking a link to a downloadable product * Fixed an issue a warning page for Grouped product with enabled MAP * Fixed an issue where a configurable product was not displayed in catalog product grid after updating with "Add configurable attributes to the new set based on current" * Fixed the inconsistent behavior in the integration tests for the Indexer functionality * Fixed an issue where the What's this? information tip link was not presented on product page with configured Minimum Advertised Price (MAP) * Processed GitHub requests: * [#742](#742) -- Admin notifications count overflow * [#720](#720) -- https filedriver is not working * [#686](#686) -- Product save validation errors in the admin don't hide the overlay * [#702](#702) -- Base table or view not found * [#652](#652) -- Multishipping checkout not to change the Billing address js issue * [#648](#648) -- An equal (=) sign in the hash of the product page to to break the tabs functionality * Service Contracts: * Refactored usage of new API of the Customer module * Implemented Service Contracts for the Sales module * Refactored Service Contracts for the Catalog module * Refactored Service Contracts for the Grouped module * UI Improvements: * Implemented the Form component in Magento UI Library * Removed extra JS loaders for category saving * Improved the behavior of Categories management in the Admin panel * Implemented the keyboard navigation through HTML elements * Improved the HTML structure and UI of the Catalog Category Link, Catalog Product Link and CMS Static Block widgets * Added UI Library documentation * Fixed Blank & Luma themes UI bugs * Fixed footer alignment * Published the Luma theme and removed the Plushe theme * Framework Improvements: * Added the ability to configure the list of loaded modules before installation * Merged SQL and Data Upgrades * Moved \Magento\TestFramework\Utility\Files to Magento Framework * Setup tool improvements: * Removed duplication with Framework * Deployment configuration is refactored from XML format in local.xml to associated array in config.php * Improved performance * Search improvements: * Integrated the Full Text Search library into the Layered Navigation functionality

verklov · 2014-12-04T06:35:23Z

Closing this ticket as fixed by #722.

[DRAGONS] Bug Fixes

…WO-58463 Fixed issues: - MAGETWO-58551 Remove uses of unserialize in Module_Quote - MAGETWO-58455 Remove uses of unserialize in \Magento\Framework\Model\ ResourceModel\Db\AbstractDb and its child classes and their usages - MAGETWO-58463 Remove uses of unserialize in Module_Sales - MAGETWO-61872 Create FieldDataConverter - MAGETWO-62133 Create QueryModifier to select only options of type file and info_buyRequest

aohorodnyk mentioned this issue Nov 1, 2014

#720 fix for those issue #722

Closed

verklov self-assigned this Nov 3, 2014

verklov added the major-accept label Nov 3, 2014

maksek added the PS label Nov 6, 2014

verklov closed this as completed Dec 4, 2014

verklov added the bug report label Dec 9, 2014

okorshenko pushed a commit that referenced this issue Oct 13, 2015

Merge pull request #720 from magento-dragons/BugFestW2

e5dedb8

[DRAGONS] Bug Fixes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Filesystem Https driver does not work with https:// links #720

Filesystem Https driver does not work with https:// links #720

mszterlingfsite commented Oct 31, 2014

aohorodnyk commented Nov 1, 2014

verklov commented Dec 4, 2014

Filesystem Https driver does not work with https:// links #720

Filesystem Https driver does not work with https:// links #720

Comments

mszterlingfsite commented Oct 31, 2014

aohorodnyk commented Nov 1, 2014

verklov commented Dec 4, 2014