Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#720 fix for those issue #722

Closed
wants to merge 1 commit into from
Closed

#720 fix for those issue #722

wants to merge 1 commit into from

Conversation

aohorodnyk
Copy link
Contributor

Hello,

I think it's a fix for issue #720 (if I fully understood description of those task).

Test cases for testing method "parseUrl" from this fix:
test input data:

geturl('https://ebay.com/test.txt'),
geturl('https://ebay.com:2000/test.txt'),
geturl('http://ebay.com:8080/test.txt'),
geturl('file://ebay.com/test.txt')

output data (used var_dump):

array(4) {
  'scheme' =>
  string(5) "https"
  'host' =>
  string(14) "ssl://ebay.com"
  'path' =>
  string(9) "/test.txt"
  'port' =>
  int(443)
}
array(4) {
  'scheme' =>
  string(5) "https"
  'host' =>
  string(14) "ssl://ebay.com"
  'port' =>
  int(2000)
  'path' =>
  string(9) "/test.txt"
}
array(4) {
  'scheme' =>
  string(4) "http"
  'host' =>
  string(8) "ebay.com"
  'port' =>
  int(8080)
  'path' =>
  string(9) "/test.txt"
}
array(3) {
  'scheme' =>
  string(4) "file"
  'host' =>
  string(8) "ebay.com"
  'path' =>
  string(9) "/test.txt"
}

Thanks, Anton

@verklov
Copy link
Contributor

verklov commented Nov 3, 2014

@dropsql, thank you for your contribution! We will review the code you provided to fix #720 and let you know the results.

@verklov verklov closed this Dec 2, 2014
okorshenko pushed a commit that referenced this pull request Oct 21, 2015
[Tango] Merchant Beta Bug Fixes
mmansoor-magento pushed a commit that referenced this pull request Jan 5, 2017
…unserialize-from-menu

Fixed issue:

- MAGETWO-60420 Remove uses of serialize/unserialize in \Magento\Backend\Model\Menu\Config
joni-jones pushed a commit to joni-jones/magento2 that referenced this pull request Jun 12, 2019
 - Merge Pull Request magento/graphql-ce#722 from Vinai/graphql-ce:fix-resolve-resolver-typo
 - Merged commits:
   1. 31ffdad
joni-jones pushed a commit to joni-jones/magento2 that referenced this pull request Jun 12, 2019
joni-jones pushed a commit to joni-jones/magento2 that referenced this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants