Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filtering, sorting and paging in the CMS entities #731

Closed
tzyganu opened this issue Nov 5, 2014 · 8 comments
Closed

Filtering, sorting and paging in the CMS entities #731

tzyganu opened this issue Nov 5, 2014 · 8 comments
Assignees
@verklov
Labels
bug report

Comments

@tzyganu
Copy link
Contributor

tzyganu commented Nov 5, 2014

Filtering and sorting does not work for CMS pages and static blocks in version alpha-102.
Also the paging does not appear.

cms pages
@antonmakarenko
Copy link

@tzyganu
Thank you for report. We have reproduced and working on it.

@vkorotun
Copy link
Contributor

Bug has been already fixed. Will be delivered to the public github repository within one of the very next pull requests.

@maksek maksek added the CS label Nov 12, 2014
magento-team added a commit that referenced this issue Nov 21, 2014
@magento-team
0.1.0-alpha105
fa214d8 
* Various improvements:
    * Merged SQL and Data Upgrades for the Tax, Weee, Customer, CustomerImportExport, ProductAlert, Sendfriend and Wishlist modules
    * Added 'Interface' suffix to all interface names
    * Stabilized functional tests for the following modules:
        * CheckoutAgreements
        * Customer
        * GiftMessage
        * Integration
        * Msrp
        * Reports
* Added the following functional tests:
    * Create product attribute from product page
* Fixed bugs:
    * Fixed an issue where bundle product price doubled during backend order creation
    * Fixed an issue where an error was thrown during Tax Rate creation, deletion and update
    * Fixed an issue where FPT was doubled when creating a refund if two FPTs were applied, and as a result the refund could not be created
    * Fixed an issue where the subtotal including tax field was not refreshed after removing downloadable product from cart
    * Fixed an issue where a downloadable link tax was not added to a product price on the product page if price was displayed including tax
    * Fixed an issue with incorrect product prices for bundle products in shopping cart
    * Fixed an issue where bundle product price was calculated incorrectly on the product page
    * Fixed an issue where configurable product options were not updated after changing currency
    * Fixed an issue where a standalone simple product and the same product as part of the grouped, were not recognized as one product in the shopping cart.
    * Fixed an issue where the incorrect tier pricing information was displayed in shopping cart
    * Fixed an issue where no notice was displayed in the shopping cart for products with MAP enabled
    * Fixed an issue where it was impossible to place an order from customer page in Admin
    * Fixed an issue where it was impossible to add address for a customer in Admin
    * Fixed an issue with broken redirect URL after deleting a product from the My Wishlist widget
    * Fixed an issue where it was impossible to assign an admin user to a user role
* Service Contracts:
    * Implemented Service Contracts for the CatalogInventory Module
* Framework Improvements:
    * Added the ability to configure the list of loaded modules before installation
    * Added the ability to use the Composer autoloader instead of the Magento custom autoloaders for tests
    * Introduced a repository for storing a quote entity
* Performance improvements:
    * Split Magento\Customer\Helper\Data
* Processed GitHub requests:
    * [#731](#731) -- Filter grid is absent on CMS Pages in Backend
@markshust
Copy link
Contributor

Somewhat related to this, only the 404 page not found record is pulling back for CMS pages on the most recent version (0.0.1-alpha105).

screen shot 2014-11-23 at 10 58 47 pm

@verklov
Copy link
Contributor

verklov commented Dec 5, 2014

@tzyganu, the fix for this issue was deployed with version 0.1.0-alpha105. Thank you!

@verklov verklov closed this as completed Dec 5, 2014
@tzyganu
Copy link
Contributor Author

tzyganu commented Dec 6, 2014

@verklov This is only one quarter solved.
The sorting on the CMS->Pages grid works. But that's it. There is not filtering. And on CMS->Static blocks grid there is still no filtering and the sorting does not work.
I checked on alpha 107. Please reopen this.

@verklov
Copy link
Contributor

verklov commented Dec 9, 2014

@tzyganu, I just pulled and installed version alpha107 from this repo and could not reproduce even a single issue you say is still there. Filtering is available in both CMS Pages and Blocks grids and work fine. Sorting also performs as expected in both grids.

@verklov verklov self-assigned this Dec 9, 2014
@tzyganu
Copy link
Contributor Author

tzyganu commented Dec 9, 2014

@verklov OK. My bad. I didn't see the "filter" button above the action dropdown. Sorry for the trouble. I guess I've seen too much of Magento 1 and got used to having each filter above the column. If it's worth something I really like the old way better. Seamed clearer than having all filters grouped in one place. But this is jut my opinion. You should ask the users about this.

@verklov
Copy link
Contributor

verklov commented Dec 9, 2014

Got you. Will forward your opinion to the PM responsible for the area. No guarantees though the decision will be different from what we have now.

mmansoor-magento pushed a commit that referenced this issue Jan 11, 2017
@balex13
Merge pull request #731 from magento-nord/SPRINT-27-NORD
cac91b5 
- MAGETWO-63042: Make price error aggregator messages more detailed
fe-lix- pushed a commit to fe-lix-/magento2 that referenced this issue Apr 6, 2018
Merge pull request magento#731 from magento-engcom/619
0758ae1 
MSI-719: Investigate fails test on Groped products
joni-jones pushed a commit to joni-jones/magento2 that referenced this issue Jun 12, 2019
@magento-engcom-team
ENGCOM-5218: Return error when invalid currentPage is provided magent…
0090efd 
…o#731

 - Merge Pull Request magento/graphql-ce#731 from pmclain/graphql-ce:issue/727
 - Merged commits:
   1. 064a4ef
   2. f361029
   3. 8c1829d
   4. 5d4520b
joni-jones pushed a commit to joni-jones/magento2 that referenced this issue Jun 12, 2019
@lenaorobei
ENGCOM-5218: Return error when invalid currentPage is provided magent…
037f7d6 
…o#731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verklov verklov

Labels
bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@markshust @antonmakarenko @maksek @tzyganu @verklov @vkorotun