Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[customer] Fixxes #10017 #10018

Closed
wants to merge 1 commit into from
Closed

[customer] Fixxes #10017 #10018

wants to merge 1 commit into from

Conversation

EliasKotlyar
Copy link
Contributor

@EliasKotlyar EliasKotlyar commented Jun 22, 2017

Description

Removed confirmation flag from the controller

Fixed Issues (if relevant)

#10017

Manual testing scenarios

Have a look at the issue

Contribution checklist

  • [x ] Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [] All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Jun 22, 2017
@okorshenko okorshenko added this to the June 2017 milestone Jun 22, 2017
@okorshenko
Copy link
Contributor

Hi @EliasKotlyar
The issue that you described is not reproducible on latest code from develop branch.
Confirmation filed is sent to the server. Everything works as expected on develop branch.
Closing this PR. Please, provide mode details about How to Reproduce the issue or close this PR if everything works for you on latest develop branch. Thank you
customer save

@okorshenko
Copy link
Contributor

Closing this PR. The login of Save controller is valid. Issue is not reproducible by provided steps. We are looking for other flows how we can reproduce it.

@okorshenko okorshenko closed this Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants