Bugfix - Multiple filter_url_params #10714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backporting bugfix from 2.2-dev branch. ref commit ca543eb Allow multiple filter_url_params params. Adding missing trailing backslash after url argument
magento-team
pushed a commit
that referenced
this pull request
Sep 1, 2017
magento-team
pushed a commit
that referenced
this pull request
Sep 1, 2017
[EngCom] Public Pull Requests - 2.1 - MAGETWO-72135: Bugfix - Multiple filter_url_params #10714
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow multiple filter_url_params params.
Description
Passing multiple filter parameters doesnt work because of missing trailing backslash when processing parameters.
Add missing trailing backslash after each url argument.
Backporting bugfix from 2.2-dev branch. ref commit ca543eb
Manual testing scenarios
Create a uiComponent and add multiple filter_url_params to the DataSource component. The generation of URL will not be correct in prepareUpdateUrl() in Magento\Framework\View\Element\UiComponent\DataProvider\DataProvider
Contribution checklist