Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of #5807: Fix minicart not cleared after order completion #10831

Closed
wants to merge 1 commit into from

Conversation

AntonEvers
Copy link
Contributor

Fixes #4460 Fixes #4416 Fixes #1461 Fixes #4969 Fixes MAGETWO-52593

(cherry picked from commit 9093ce9)

Description

Fixed Issues (if relevant)

  1. magento/magento2#<issue_number>: Issue title
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Fixes magento#4460 Fixes magento#4416 Fixes magento#1461 Fixes magento#4969 Fixes MAGETWO-52593

(cherry picked from commit 9093ce9)
@ihor-sviziev
Copy link
Contributor

ihor-sviziev commented Sep 11, 2017

Original #5807 PR wasn't merged, fix was implemented in different way, so it should be done in the same way.
Also looks like it was already fixed in 2.1-develop by #10050

@reijervano
Copy link

Guys,

this pull request does not fix the problem!

@CNanninga
Copy link

In my experience, this issue does still exist in 2.1.9. #10050 doesn't fix the specific issue wherein the mini-cart still shows its old contents after completing an order.

Whether the appropriate implementation or not, this PR does fix it. (Though you must implement the same template change in additional templates if your theme or a custom extension is overriding the order success page.)

@AntonEvers
Copy link
Contributor Author

I fully agree that this PR is not the proper solution. But as a hotfix it's ok. I'd rather see that not only POST and AJAX calls can invalidate the cart cache but also regular page requests. Let's work on a proper solution from here. I was asked to backport this by the Magento developers.

@vkublytskyi
Copy link

@ajpevers as original PR #5807 was closed and not merged into develop branch and I was not able to reproduce linked issues on 2.1-develop branch I close this PR. If the issue is still valid, please provide steps to reproduce for actual 2.1 version to reopen this PR.

@AntonEvers
Copy link
Contributor Author

Hi @vkublytskyi,

Can you please contact @vrann on this issue? He asked me on 1 september: [8:54 PM]
@anton.evers Hi! would you be interested to make a backport this issue to 2.1? #5807

Thanks,

Anton

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants