Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dob date validation on custom locale #11067

Merged
merged 4 commits into from
Sep 27, 2017

Conversation

joachimVT
Copy link

@joachimVT joachimVT commented Sep 26, 2017

Description

Validations not working on customer registration on DOB field when changing the default locale. This pull request fixed the javascript date validation.

Fixed Issues (if relevant)

  1. Frontend: Datepicker/calendar control does not use the store locale #6350
  2. Invalid date when customer validate with French locale #9743
  3. DatePicker date format does not reflect user's locale #6858
  4. Magento 2.1.1 Invalid input date format 'Invalid date' #6831
  5. Validations not working on customer registration on DOB field.  #4248

Manual testing scenarios

  1. Set Backoffice to Dutch locale : account settings ->language Dutch (Dutch)
  2. Modify a customer and set date of birthday (for example : 24-11-1980)

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Sep 26, 2017
@okorshenko okorshenko added this to the September 2017 milestone Sep 26, 2017
@vrann vrann self-assigned this Sep 26, 2017
@vrann vrann merged commit c7f318c into magento:2.2-develop Sep 27, 2017
@nelero
Copy link

nelero commented Sep 27, 2017

same problem with start/end date for catalog rule

@digvijay2017
Copy link

This issue still exists in Magento 2.2.1, while i have set Interface Locale UK from admin setting.
magento2-1-1

@magento-engcom-team magento-engcom-team added Admin Panel bugfix Component: Customer Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Area: Frontend Component: Translation labels Nov 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants