Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in stripped min length validation when value has special characters #11084

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Conversation

rubenRP
Copy link

@rubenRP rubenRP commented Sep 27, 2017

Fix in stripped min length validation when value has special characters

Description

When add a UI Component form with stripped-min-lenght validation and the input has special characters, the console shows a javascript error (Syntax error: Unrecognized expression...) because uses jQuery instead native Javascript function.

Fixed Issues (if relevant)

  1. stripped-min-length Validation via UI Component Fails with "special" characters #9920

Manual testing scenarios

  1. Create a UI Component based form

  2. Add the following validation to the XML form element definition

<item name="validation" xsi:type="array">
    <item name="required-entry" xsi:type="boolean">true</item>
    <item name="no-whitespace" xsi:type="boolean">true</item>
    <item name="stripped-min-length" xsi:type="string">4</item>
</item>
  1. Test in admin using value a/b or ab/ or a&c

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 27, 2017

CLA assistant check
All committers have signed the CLA.

@@ -244,7 +244,7 @@ define([
],
'stripped-min-length': [
function (value, param) {
return $(value).text().length >= param;
return value.length >= param;
Copy link

@vkublytskyi vkublytskyi Sep 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a rule has stripped-min-length name, value should be stripped (use utils.stripHtml).

A simple check on >= param will make any field with this validation rule required. To avoid this implementation should be aligned with implementation of min_text_length rule.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"As a rule has stripped-min-length name, value should be stripped (use utils.stripHtml)." OK

"A simple check on >= param will make any field with this validation rule required. To avoid this implementation should be aligned with implementation of min_text_length rule." When you say "should be aligned" I should validate the values like min_text_length (return _.isUndefined(value) || value.length === 0 || utils.stripHtml(value) >= params;) or I should use min_text_lenght function?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function reuse is preferred as it reduces code duplication but as there is no much code it is ok just to make same check inside stripped-min-length

…alue has special characters using alignment with implementation of min_text_length
Copy link
Author

@rubenRP rubenRP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix in stripped min lenght validation when value has special characters using alignment with implementation of min_text_length

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants