-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix in stripped min length validation when value has special characters #11084
Conversation
…alue has special characters
@@ -244,7 +244,7 @@ define([ | |||
], | |||
'stripped-min-length': [ | |||
function (value, param) { | |||
return $(value).text().length >= param; | |||
return value.length >= param; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a rule has stripped-min-length
name, value should be stripped (use utils.stripHtml
).
A simple check on >= param
will make any field with this validation rule required. To avoid this implementation should be aligned with implementation of min_text_length
rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"As a rule has stripped-min-length name, value should be stripped (use utils.stripHtml)." OK
"A simple check on >= param will make any field with this validation rule required. To avoid this implementation should be aligned with implementation of min_text_length rule." When you say "should be aligned" I should validate the values like min_text_length (return _.isUndefined(value) || value.length === 0 || utils.stripHtml(value) >= params;) or I should use min_text_lenght function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Function reuse is preferred as it reduces code duplication but as there is no much code it is ok just to make same check inside stripped-min-length
…alue has special characters using alignment with implementation of min_text_length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix in stripped min lenght validation when value has special characters using alignment with implementation of min_text_length
Fix in stripped min length validation when value has special characters
Description
When add a UI Component form with stripped-min-lenght validation and the input has special characters, the console shows a javascript error (Syntax error: Unrecognized expression...) because uses jQuery instead native Javascript function.
Fixed Issues (if relevant)
Manual testing scenarios
Create a UI Component based form
Add the following validation to the XML form element definition
a/b
orab/
ora&c
Contribution checklist