Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in stripped min length validation when value has special characters #11084

Merged
merged 2 commits into from
Oct 6, 2017
Merged

Fix in stripped min length validation when value has special characters #11084

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e5c8f0
ISSUE#9920 MAGETWO-75838 Fix in stripped min lenght validation when v…
Sep 27, 2017
6be8769
ISSUE#9920 MAGETWO-75838 Fix in stripped min lenght validation when v…
Sep 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ define([
],
'stripped-min-length': [
function (value, param) {
return $(value).text().length >= param;
return value.length >= param;
Copy link

@vkublytskyi vkublytskyi Sep 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a rule has stripped-min-length name, value should be stripped (use utils.stripHtml).

A simple check on >= param will make any field with this validation rule required. To avoid this implementation should be aligned with implementation of min_text_length rule.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"As a rule has stripped-min-length name, value should be stripped (use utils.stripHtml)." OK

"A simple check on >= param will make any field with this validation rule required. To avoid this implementation should be aligned with implementation of min_text_length rule." When you say "should be aligned" I should validate the values like min_text_length (return _.isUndefined(value) || value.length === 0 || utils.stripHtml(value) >= params;) or I should use min_text_lenght function?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function reuse is preferred as it reduces code duplication but as there is no much code it is ok just to make same check inside stripped-min-length

},
$.mage.__('Please enter at least {0} characters')
],
Expand Down