Fixed issue #10738: Don't display attribute label if defined as "none" in layout #11168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR fix issue when attribute label name in
app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml
defined asnone
to hide from rendering, but there is translation fornone
in another locale, which force rendering the label.Only layout instruction can define "none" as keyword for skip rendering label in
attrubute.phtml
template. If an attribute has label "none" defined in admin attribute settings, it must be generated as defined, and template must not read it as instruction to hide.Fixed Issues (if relevant)
Manual testing scenarios
Add new store view with another locale (language)
Translate "none" in new local to another language (different from "none")
Create new product, with some short description
Open product on product details view in English locale
Change local
In steps 4 and 5 - no label for "short description" must be rendered
Change default store label for "SKU" to "none" in admin attribute settings
Open product on product details view in English local - "none" must be displayed instead of SKU.
Change 'description' attribute value
Contribution checklist