Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #10738: Don't display attribute label if defined as "none" in layout #11168

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Fixed issue #10738: Don't display attribute label if defined as "none" in layout #11168

merged 1 commit into from
Oct 4, 2017

Conversation

maksek
Copy link
Contributor

@maksek maksek commented Oct 1, 2017

Description

PR fix issue when attribute label name in app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml defined as none to hide from rendering, but there is translation for none in another locale, which force rendering the label.

Only layout instruction can define "none" as keyword for skip rendering label in attrubute.phtml template. If an attribute has label "none" defined in admin attribute settings, it must be generated as defined, and template must not read it as instruction to hide.

Fixed Issues (if relevant)

  1. Empty attribute label is displayed on product page when other language used. #10738: Empty attribute label is displayed on product page

Manual testing scenarios

  1. Add new store view with another locale (language)

  2. Translate "none" in new local to another language (different from "none")

  3. Create new product, with some short description

  4. Open product on product details view in English locale

  5. Change local

  6. In steps 4 and 5 - no label for "short description" must be rendered

  7. Change default store label for "SKU" to "none" in admin attribute settings

  8. Open product on product details view in English local - "none" must be displayed instead of SKU.

  9. Change 'description' attribute value

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Oct 1, 2017

CLA assistant check
All committers have signed the CLA.

@okorshenko
Copy link
Contributor

@maksek thank you for your contribution. Could you please sign CLA so that we can proceed with PR acceptance? Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants