Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty attribute label is displayed on product page when other language used. #10738

Closed
nowszy opened this issue Sep 1, 2017 · 10 comments
Closed

Empty attribute label is displayed on product page when other language used. #10738

nowszy opened this issue Sep 1, 2017 · 10 comments
Assignees
@maksek
Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release

Comments

@nowszy
Copy link
Contributor

nowszy commented Sep 1, 2017

Preconditions

  1. Clean instance of Magento 2.1.8
  2. Store displayed in some foreign languege i.e. pl_PL
  3. Simple product with some attribute visible on product page.

Steps to reproduce

  1. Go to product page.
  2. See attribute label ('none' translated to your foreign language) in the attributes section/

Expected result

  1. 'none' label translated to other languages i.e. polish lang - 'brak' should not be displayed
  2. comparisson in line 37 of app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml is changed to if ($_attributeLabel != __('none')) in order to not display 'none' translated to foreign language

Actual result

  1. In the template app/code/Magento/Catalog/view/frontend/templates/product/view/attribute.phtml line 37 you have followin comparisson: if ($_attributeLabel != 'none') but at this part of code $_attributeLabel is already translated.
nowszy added a commit to nowszy/magento2 that referenced this issue Sep 1, 2017
@nowszy
magento#10738
093e742 
Fix for translated attribute label comparisson. Refs magento#10738
@nowszy nowszy mentioned this issue Sep 1, 2017
Merged
@korostii
Copy link
Contributor

korostii commented Sep 7, 2017

FYI: This has been reported may times before: #9295, #9161, #9531,

@magento-engcom-team magento-engcom-team added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed and removed G1 Passed labels Sep 7, 2017
@orlangur orlangur mentioned this issue Sep 11, 2017
Closed
@orlangur orlangur added the 2.1.x label Sep 11, 2017
@orlangur orlangur mentioned this issue Sep 11, 2017
Closed
@magento-engcom-team magento-engcom-team added bug report Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed labels Sep 11, 2017
@orlangur
Copy link
Contributor

orlangur commented Sep 11, 2017 •
edited
Loading

Ok, so, there are (at least) two attempts to fix this issue. Both merged to develop and none to 2.1-develop:

According to my understanding newer PR is a correct one (no reason to forbid "none" translation, valid scenario is described in this issue), thus it would be nice to revert #6257.

Thoughts? Cc: @vrann @miguelbalparda

@okorshenko okorshenko added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Sep 14, 2017
@Januszpl Januszpl mentioned this issue Sep 17, 2017
Merged
@magento-engcom-team
Copy link
Contributor

@nowszy, thank you for your report.
The issue is already fixed in develop branch
But we will consider to backport the fix to patch releases

@magento-engcom-team magento-engcom-team added Fixed in 2.3.x The issue has been fixed in 2.3 release line Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release 2.2.x labels Sep 19, 2017
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-75315

@magento-team magento-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Sep 22, 2017
@maksek
Copy link
Contributor

maksek commented Oct 1, 2017

@orlangur, the more correct in 2.2-develop branch. Remove translate="true" from layout and do not translate "none" in template.

@maksek maksek self-assigned this Oct 1, 2017
This was referenced Oct 1, 2017
Merged
Merged
@orlangur
Copy link
Contributor

orlangur commented Oct 2, 2017

@maksek ok, thanks for sorting this out 👍

okorshenko pushed a commit that referenced this issue Oct 4, 2017
MAGETWO-80884: Fixed issue #10738: Don't display attribute label if d…
67d265d 
…efined as 'none' in layout #11168

 - Merge Pull Request #11168 from maksek/magento2:none_transaltion_fix
 - Merged commits:
   1. 3c68ca8
okorshenko pushed a commit that referenced this issue Oct 4, 2017
MAGETWO-80884: Fixed issue #10738: Don't display attribute label if d…
a0d2a7d 
…efined as "none" in layout #11168
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-80884

@okorshenko
Copy link
Contributor

@nowszy thank you for your report. The issue is already fixed in 2.2-develop branch (PR: #11168 by @maksek ) and will be available in the Magento 2.2.2 release

magento-team pushed a commit that referenced this issue Oct 5, 2017
MAGETWO-80770: Fixed issue #10738: Don't display attribute label if d…
1aa35d4 
…efined as 'none' in layout (develop branch) #11169

 - Merge Pull Request #11169 from maksek/magento2:fix_none_issue__develop
 - Merged commits:
   1. f9562f1
magento-team pushed a commit that referenced this issue Oct 5, 2017
MAGETWO-80770: Fixed issue #10738: Don't display attribute label if d…
9a883f6 
…efined as "none" in layout (develop branch) #11169
@magento-team
Copy link
Contributor

Internal ticket to track issue progress: MAGETWO-80770

hostep pushed a commit to hostep/magento2 that referenced this issue Feb 7, 2018
@maksek @hostep
Fixed issue magento#10738: Empty attribute label is displayed on prod…
00f29c0 
…uct page when other language used

(cherry picked from commit f9562f1)
@hostep hostep mentioned this issue Feb 7, 2018
Merged
4 tasks
@magento-engcom-team
Copy link
Contributor

Hi @nowszy. Thank you for your report.
The issue has been fixed in #13532 by @hostep in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.13 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.1.x The issue has been fixed in 2.1 release line label Feb 12, 2018
magento-engcom-team pushed a commit that referenced this issue Feb 12, 2018
@orlangur
MAGETWO-87521: Fixed issue #10738: Empty attribute label is displayed…
b53e1fd 
… on product pag… #13532

 - Merge Pull Request #13532 from hostep/magento2:backport-pr-11169
 - Merged commits:
   1. 00f29c0
magento-engcom-team pushed a commit that referenced this issue Feb 12, 2018
MAGETWO-87521: Fixed issue #10738: Empty attribute label is displayed…
b6bfc6d 
… on product pag… #13532
@magento-engcom-team magento-engcom-team added Fixed in develop Fixed in 2.2.x The issue has been fixed in 2.2 release line labels Feb 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maksek maksek

Labels
bug report Fixed in 2.1.x The issue has been fixed in 2.1 release line Fixed in 2.2.x The issue has been fixed in 2.2 release line Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@orlangur @magento-team @maksek @okorshenko @vherasymenko @nowszy @korostii @magento-engcom-team