Fixed issue #10738: Don't display attribute label if defined as "none" in layout (develop branch)

[maksek]

Description

PR fix issue when attribute label name in app/code/Magento/Catalog/view/frontend/layout/catalog_product_view.xml defined as none to hide from rendering, but there is translation for none in another locale, which force rendering the label.

Only layout instruction can define "none" as keyword for skip rendering label in attrubute.phtml template. If an attribute has label "none" defined in admin attribute settings, it must be generated as defined, and template must not read it as instruction to hide.

Fixed Issues (if relevant)

1. Empty attribute label is displayed on product page when other language used. #10738: Empty attribute label is displayed on product page

Manual testing scenarios

1. Add new store view with another locale (language)

2. Translate "none" in new local to another language (different from "none")

3. Create new product, with some short description

4. Open product on product details view in English locale

5. Change local

6. In steps 4 and 5 - no label for "short description" must be rendered

7. Change default store label for "SKU" to "none" in admin attribute settings

8. Open product on product details view in English local - "none" must be displayed instead of SKU.

9. Change 'description' attribute value

Contribution checklist

• [] Pull request has a meaningful description of its purpose
• [] All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[magento-cicd2]

All committers have signed the CLA.

[okorshenko]

@maksek thank you for your contribution. Could you please sign CLA so that we can proceed with PR acceptance? Thank you

[vrann]

This PR contradicts with two other PRs which fixed the same issue in another way:

• label is made translatable (upon issue Fix for translated attribute label comparisson. #10739): Make labels translatable for Overview and Details sections on product… #10933
• javascript takes into account already translated label and does not display it: Fix for translated attribute label comparisson. #10739

Having both pull requests are accepted, issue had to be fixed in the develop branch. Is it still reproduceable?

[okorshenko]

@vrann @maksek investigated the issue. PR to develop branch should align fixes with 2.2-develop branch. Without this PR and after forward porting the fixes from 2.2-develop the issue will appear again. So We have 2 PRs (to develop and 2.2-develop) with aligned approaches.

[hostep]

This fix should get backported to 2.1, because since Magento 2.1.10, we see 'none' showing up on certain product detail pages.
Problem was introduced by PR #10932

Applying the fix from this PR in a custom patch in our projects seems to resolve the problem.