Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #10739 - fix for translated attribute label comparison. #10932

Merged
merged 2 commits into from
Sep 22, 2017
Merged

Backport #10739 - fix for translated attribute label comparison. #10932

merged 2 commits into from
Sep 22, 2017

Conversation

Januszpl
Copy link

@Januszpl Januszpl commented Sep 17, 2017

Description

Backport fix from #10739 plus make also Details section translatable that uses also attributes.phtml

Fixed Issues (if relevant)

  1. Empty attribute label is displayed on product page when other language used. #10738: Empty attribute label is displayed on product page when other language used. #10738

Manual testing scenarios

  1. set store to use other lang
  2. set/create attribute with locale translation label for ex instead of "none" "brak" (polish translation)
  3. assing attribute to product
  4. on product page in short description and in detail tabs content shouldn't be displayed "none/brak" attribute

Janusz Janczy added 2 commits September 17, 2017 11:26
…iption section after label comparison fix had been applied in attribute template. Refs #10738
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Sep 17, 2017

CLA assistant check
All committers have signed the CLA.

@orlangur
Copy link
Contributor

Whoever will review this PR, please check #10738 (comment) - we should leave only one version of fix (according to my understanding label should be translatable).

@orlangur
Copy link
Contributor

Oh, excellent, my suggestion is addressed in #10933. Good job @Januszpl !

@orlangur orlangur self-assigned this Sep 18, 2017
@magento-team magento-team merged commit 622cd47 into magento:2.1-develop Sep 22, 2017
@vrann
Copy link
Contributor

vrann commented Oct 4, 2017

@Januszpl can you please remind me, why do you want to have translate=true on Details section, isn't it affecting only the attribute value none which is not displayed anyway?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants