-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.1-develop] #11409: Too many password reset requests even when disabled in settings #11436
Merged
magento-team
merged 1 commit into
magento:2.1-develop
from
adrian-martinez-interactiv4:FR21#11409-TOO-MANY-PASSWORD-RESET-REQUESTS
Dec 7, 2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrian-martinez-interactiv4
changed the title
[Backport 2.1-develop] Issue #11409: Too many password reset requests even when disabled in settings
[Backport 2.1-develop] #11409: Too many password reset requests even when disabled in settings
Oct 14, 2017
See #11434 (comment) for comment on change. |
adrian-martinez-interactiv4
force-pushed
the
FR21#11409-TOO-MANY-PASSWORD-RESET-REQUESTS
branch
2 times, most recently
from
October 28, 2017 15:57
af932aa
to
ebdd554
Compare
I will put this on hold until #11434 has been merged into 2.3-develop |
magento-engcom-team
added
2.2.x
Reproduced on 2.1.x
The issue has been reproduced on latest 2.1 release
Reproduced on 2.2.x
The issue has been reproduced on latest 2.2 release
Reproduced on 2.3.x
The issue has been reproduced on latest 2.3 release
labels
Nov 7, 2017
Now that #11434 has been sorted can you make the same changes into the backported PRs @adrian-martinez-interactiv4 |
adrian-martinez-interactiv4
force-pushed
the
FR21#11409-TOO-MANY-PASSWORD-RESET-REQUESTS
branch
2 times, most recently
from
November 30, 2017 18:14
4db4015
to
b4dbe4c
Compare
adrian-martinez-interactiv4
force-pushed
the
FR21#11409-TOO-MANY-PASSWORD-RESET-REQUESTS
branch
from
December 1, 2017 10:13
b4dbe4c
to
fca05b2
Compare
@will-b this issue was previous to this PR, replaced all double spaces after = sign in that file. |
magento-team
pushed a commit
that referenced
this pull request
Dec 7, 2017
… requests even when disabled in settings #11436
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Award: complex
Award: test coverage
Progress: accept
Progress: on hold
Release Line: 2.1
Reproduced on 2.1.x
The issue has been reproduced on latest 2.1 release
Reproduced on 2.2.x
The issue has been reproduced on latest 2.2 release
Reproduced on 2.3.x
The issue has been reproduced on latest 2.3 release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to reset a customer's password via the admin, the system tells me 'Too many password reset requests' even when I have disabled the 'max wait time between password resets' in the store configuration settings.
Related with PR#11434
Description
\Magento\Security\Model\Config::getXmlPathPrefix() method fails to use the customer configuration
customer/password/
, using theadmin/security/
settings instead, when reset password is triggered from admin, due to current scope:Emulated frontend area in scope in plugin method \Magento\Security\Model\Plugin\AccountManagement::beforeInitiatePasswordReset, also fixed di.xml parameter injection that caused customer password reset requests also counting as admin user requests when emails coincide for admin user and customer.
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist