Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #8009 #12548

Merged
merged 1 commit into from
Dec 7, 2017
Merged

Fixes #8009 #12548

merged 1 commit into from
Dec 7, 2017

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Dec 5, 2017

Description

Flush full page cache for all products that have been reindexed. Not only the child products, but also parent products. This is already the case in 2.2-develop.

Fixed Issues (if relevant)

  1. Magento 2.1.3 out of stock associated products to configurable are not full page cache cleaned #8009: Magento 2.1.3 out of stock associated products to configurable are not full page cache cleaned

Manual testing scenarios

preconditions: set indexers to scheduled and install sample data for configurable products

  1. buy all available simples of a configurable product, so they become out of stock
  2. run the indexer_update_all_views cron job
  3. refresh the product detail page
  4. the product should now be out of stock

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Flush full page cache for all products that have been reindexed. Not only the child products, but also parent products. This is already the case in 2.2-develop.
@adrian-martinez-interactiv4
Copy link
Contributor

Hi @ajpevers , thank you for your contribution. Changes from this PR look good and have been accepted, would you consider to backport them to 2.2-develop and 2.3-develop versions if needed? It also would be nice the PR and the commits have meaningful messages about changes performed in the pull request, so changes motivations are easier to understand in the future when seeking git history.

@AntonEvers
Copy link
Contributor Author

Hi @adrian-martinez-interactiv4, In 2.2-develop and 2.3-develop this is already taken care of. Thanks.

@magento-team magento-team merged commit 91061af into magento:2.1-develop Dec 7, 2017
magento-team pushed a commit that referenced this pull request Dec 7, 2017
magento-team pushed a commit that referenced this pull request Dec 7, 2017
[EngCom] Public Pull Requests - 2.1-develop
 - MAGETWO-85104: Fixes #8009 #12548
 - MAGETWO-84861: [Backport 2.1-develop] #11409: Too many password reset requests even when disabled in settings #11436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants