Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2-develop] FIX show visual swatches in admin - product attribute #11747

Merged

Conversation

enriquei4
Copy link
Contributor

@enriquei4 enriquei4 commented Oct 25, 2017

Description

Backport of PR: FIX show visual swatches in admin - product attribute #11661

Visual swatch wasn't shown full menu, I only fix some CSS to show full menu. Now the menu is showed correctly.

Fixed Issues (if relevant)

Values of Visual Swatch Attribute drop down is not work correct #11534

Manual testing scenarios

  1. Go to Admin
  2. Open Stores > Attributes > Product
  3. Add New Attribute with Catalog Input Type for Store Owner: Visual Swatch
  4. In Tab Manage Swatch (Values of Your Attribute) click Add Swatch button
  5. Press to chose color or file
  6. Now is fixed to rendered the menu with all items.

BEFORE:
screen shot 2017-10-24 at 08 50 41

NOW:
screen shot 2017-10-24 at 08 45 55

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@enriquei4 enriquei4 changed the title FIX show visual swatches in admin - product attribute [Backport 2.2] [Backport 2.2-develop] FIX show visual swatches in admin - product attribute Oct 25, 2017
@ishakhsuvarov ishakhsuvarov self-assigned this Oct 28, 2017
@ishakhsuvarov ishakhsuvarov added this to the October 2017 milestone Oct 28, 2017
@ishakhsuvarov ishakhsuvarov added Release Line: 2.2 2.2.x Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 28, 2017
@magento-team magento-team merged commit 19d4264 into magento:2.2-develop Oct 31, 2017
magento-team pushed a commit that referenced this pull request Oct 31, 2017
magento-team pushed a commit that referenced this pull request Oct 31, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-82955: [Backport 2.2-develop] FIX show visual swatches in admin - product attribute #11747
 - MAGETWO-82943: Magetwo 70954: Remove the component.clear from the custom options type. This causes the 'elem' array to become out of sync with the recordData #11824
 - MAGETWO-82710: Fix issue #10032 - Download back-up .tgz always takes the latest that's created (2.2-develop) #11595
 - MAGETWO-81994: Products added to cart with REST API give total prices equal to zero #11458
 - MAGETWO-81422: #11211 Fix Store View switcher #11337
@leoncito73
Copy link

leoncito73 commented Nov 1, 2017

hello, I try to fix this issue copying the CSS code, but I can't find where is this file swatches.css
Magento 2.2.0
PHP 7.1.0
When I search in this: app/code/Magento/Swatches/view/adminhtml/web/css/swatches.css
the folder "Magento" doesn't exist, I should have to create full root?
captura de pantalla 2017-11-01 a las 10 20 52

@Ctucker9233
Copy link

@leoncito73 You should be able to find it in vendor/magento/module-swatches/view/adminhtml/web/css/swatches.css

@leoncito73
Copy link

@Ctucker9233 thanks.. yes was solved time ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: accept Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants