Magetwo 70954: Remove the component.clear from the custom options type. This causes the 'elem' array to become out of sync with the recordData

[briscoda]

Description

The issue here is that when switching custom options types in the product edit screen, there can be instances where there is a perpetual spinner that is shown. In my findings, this was because there were 2 variables and 1 function that were checked to be 'in-sync' with each other as far as the length of items in each javascript array.

"recordData", "elems", and function "getChildItems". These three pieces were in the "dynamic-rows.js" file. As far as I could tell, the spinner in is not something that would ever make sense to be used in this case. However, because it was listed as an observable of elems, and elems was used for other things, it seemed to make more sense to find the cause of why elems would be 0 when it needed to match the getChildItems function.

Tracing this back, "elems" was part of the UiSelect object, and it was doing a component.clear() whenever the value of the option type selector changed. There is also no history from this file before: 566be67#diff-2c1b11e20e699888b25df7c484e62d20

So it was difficult to say if this was added in or generated. I search the code base for instances of uses of the UiSelect as a component to clear values, and didn't find anything that seemed exceptional, so I think this removal would be localized to only thes adminhtml custom options.

Fixed Issues (if relevant)

1. Magento 2 Loading custom option dropdown issue #10291: Magento 2 Loading custom option dropdown issue

Manual testing scenarios

1. Login to the admin
2. Go to catalog / product
3. Add new or editExisting product
4. Add custom option
5. Use dropdown select and add a value
6. Change to file or other type of option that is not select.
7. Change back to select type.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)