Fixed a js bug where ui_component labels have the wrong sort order.

[deiserh]

Description

If you extend an dynamic-row element in a ui_component and add a sort order attribute with a amount between the others, the Fields are in the correct order but the label is always the last one.

Manual testing scenarios

1. Extend an dynamic-row in a ui_component with a sort order so your element isn't the last one.
   Result: The label are in the correct sort order (your Field Label isn't the last one).

[magento-cicd2]

All committers have signed the CLA.

[omiroshnichenko]

Could you, please, move push and sort calls outside of loop for performance improvement. Also, I think it's better to use _.sortBy() function and remove custom compare function. An example:

initHeader: function () {
    var labels = [],
        data;

    if (!this.labels().length) {
        _.each(this.childTemplate.children, function (cell) {
            data = this.createHeaderTemplate(cell.config);
            cell.config.labelVisible = false;
            _.extend(data, {
                label: cell.config.label,
                name: cell.name,
                required: !!cell.config.validation,
                columnsHeaderClasses: cell.config.columnsHeaderClasses,
                sortOrder: cell.config.sortOrder
            });

            labels.push(data);
        }, this);
        this.labels(_.sortBy(labels, 'sortOrder'));
    }
}

[omiroshnichenko]

It's would be nice if you will mark dynamic-rows-tier-price.js as deprecated, because it was created by mistake for fix same issue, but just for tier price functionality.

[omiroshnichenko]

Hi, @deiserh. I have made update for your code. Thank you for contribution.