Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a js bug where ui_component labels have the wrong sort order. #11846

Merged
merged 4 commits into from
Nov 22, 2017
Merged

Fixed a js bug where ui_component labels have the wrong sort order. #11846

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f948ac
Fixed a js bug where ui_component labels have the wrong sort order.
deiserh Oct 29, 2017
6f70d06
MAGETWO-83993: Fixed a js bug where ui_component labels have the wron…
omiroshnichenko Nov 16, 2017
8f52242
Merge branch '2.2-develop' of github.com:magento/magento2 into fix-ui…
omiroshnichenko Nov 16, 2017
c464951
Merge branch '2.2-develop' of github.com:magento/magento2 into fix-ui…
omiroshnichenko Nov 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions app/code/Magento/Ui/view/base/web/js/dynamic-rows/dynamic-rows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,13 @@ define([
});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's would be nice if you will mark dynamic-rows-tier-price.js as deprecated, because it was created by mistake for fix same issue, but just for tier price functionality.


this.labels.push(data);

/**
* Sort the array after an element was added to fix an bug where
* additional added field labels in ui_components haven't the right
* sort order.
*/
this.labels.sort(this._compare);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, please, move push and sort calls outside of loop for performance improvement. Also, I think it's better to use _.sortBy() function and remove custom compare function. An example:

initHeader: function () {
    var labels = [],
        data;

    if (!this.labels().length) {
        _.each(this.childTemplate.children, function (cell) {
            data = this.createHeaderTemplate(cell.config);
            cell.config.labelVisible = false;
            _.extend(data, {
                label: cell.config.label,
                name: cell.name,
                required: !!cell.config.validation,
                columnsHeaderClasses: cell.config.columnsHeaderClasses,
                sortOrder: cell.config.sortOrder
            });

            labels.push(data);
        }, this);
        this.labels(_.sortBy(labels, 'sortOrder'));
    }
}

}, this);
}
},
Expand Down Expand Up @@ -914,6 +921,24 @@ define([
}));
},

/**
* Compare two objects by the sortOrder property.
*
* @param {Object} $object1
* @param {Object} $object2
* @returns {Number}
* @private
*/
_compare: function ($object1, $object2) {
if ($object1.sortOrder > $object2.sortOrder) {
return 1;
} else if ($object1.sortOrder < $object2.sortOrder) {
return -1;
}

return 0;
},

/**
* Set new data to dataSource,
* delete element
Expand Down