-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#8810 - REST API - Attribute option creation -> no ID returned #11928
#8810 - REST API - Attribute option creation -> no ID returned #11928
Conversation
Hi! Thank you for your contribution. As this PR modifies the signature of an interface annotated with @okorshenko, please can you have a look? |
Hi @sanjay-wagento, please can you let me know whether you want to rebase this PR against Thanks and happy holidays! |
@mzeis , Yes, I will do rebase |
@sanjay-wagento Perfect, thank you! |
Thank you, I will close this one then. |
Also duplicate of #6300 |
Set option_id in value field to attributeoptioninterface return type
Description
I have changed return type of add function and set value to option. So when we do REST or SOAP api then it will return option_id in 'value' field to attributeoptioninterface return type.
Fixed Issues (if relevant)
Manual testing scenarios
POST /rest/default/V1/products/attributes/manufacturer/options
with following Body:
{ "option": { "label": "Manufacturer 1" } }
Contribution checklist