Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8810 - REST API - Attribute option creation -> no ID returned #11928

Closed
wants to merge 1 commit into from
Closed

#8810 - REST API - Attribute option creation -> no ID returned #11928

wants to merge 1 commit into from

Conversation

sanjay-wagento
Copy link
Contributor

Set option_id in value field to attributeoptioninterface return type

Description

I have changed return type of add function and set value to option. So when we do REST or SOAP api then it will return option_id in 'value' field to attributeoptioninterface return type.

Fixed Issues (if relevant)

  1. REST API - Attribute option creation -> no ID returned #8810: REST API - Attribute option creation -> no ID returned

Manual testing scenarios

  1. Fresh install
  2. Make following REST request:
    POST /rest/default/V1/products/attributes/manufacturer/options
    with following Body:
    { "option": { "label": "Manufacturer 1" } }

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 1, 2017

CLA assistant check
All committers have signed the CLA.

@mzeis mzeis self-assigned this Nov 1, 2017
@mzeis mzeis added Release Line: 2.2 bugfix Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog labels Nov 1, 2017
@mzeis
Copy link
Contributor

mzeis commented Nov 1, 2017

Hi!

Thank you for your contribution. As this PR modifies the signature of an interface annotated with @api, you might have to rebase the PR against 2.3-develop (even when it's a bugfix).

@okorshenko, please can you have a look?

@magento-engcom-team magento-engcom-team added 2.2.x Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 7, 2017
@okorshenko okorshenko removed the 2.2.x label Dec 14, 2017
@mzeis
Copy link
Contributor

mzeis commented Dec 27, 2017

Hi @sanjay-wagento,

please can you let me know whether you want to rebase this PR against 2.3-develop?

Thanks and happy holidays!

@sanjay-wagento
Copy link
Contributor Author

@mzeis , Yes, I will do rebase

@mzeis
Copy link
Contributor

mzeis commented Dec 29, 2017

@sanjay-wagento Perfect, thank you!

@sanjay-wagento
Copy link
Contributor Author

@mzeis , I created pull request for 2.3-develop branch at #12920

@mzeis
Copy link
Contributor

mzeis commented Dec 29, 2017

Thank you, I will close this one then.

@milindsingh
Copy link
Member

Also duplicate of #6300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Component: Framework/Webapi USE ONLY for FRAMEWORK RELATED BUG! E.g If bug related to Catalog WEB API use just Catalog Progress: needs update Progress: reject Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants