Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.2] MAGETWO-71697: Fix possible bug when saving address with empty street line #10582 #12130

Merged

Conversation

vovayatsyuk
Copy link
Member

Cherry-pick of 5858ca5
Original PR: #10582

Description

The changes affect address street data preparation to guarantee that street array will be converted to the string.

Manual testing scenarios

  1. Make the street address as an optional field (third-party extension is required or edit DB properties of the field)
  2. Save the address without street
  3. exception 'Exception' with message 'Notice: Array to string conversion on line 2903 in lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php will be raised.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@ishakhsuvarov ishakhsuvarov self-assigned this Nov 10, 2017
@ishakhsuvarov ishakhsuvarov added this to the November 2017 milestone Nov 10, 2017
@okorshenko okorshenko merged commit db377d0 into magento:2.2-develop Nov 13, 2017
okorshenko pushed a commit that referenced this pull request Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants