Fix possible bug when saving address with empty street line

[vovayatsyuk]

Description

The changes affect address street data preparation to guarantee that street array will be converted to the string.

Manual testing scenarios

1. Make the street address as an optional field (third-party extension is required or edit DB properties of the field)
2. Save the address without street
3. exception 'Exception' with message 'Notice: Array to string conversion on line 2903 in lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php will be raised.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds on Travis CI are green)

[ishakhsuvarov]

@vovayatsyuk Please take a look at the failed unit tests.

[vovayatsyuk]

Hi!

Don't know if I did it right, please take a look. (I've added a suppress instruction for failed static test)

[ishakhsuvarov]

@vovayatsyuk Thank you for the update. We will proceed with review and merge.

[ishakhsuvarov]

@vovayatsyuk I've tried to reproduce the described scenario with the develop branch and could not get any E_NOTICE level errors.
I've followed these steps:

• Make street non-required and remove validation options in Customer module Setup Scripts.
• Comment out hard-coded address validation in \Magento\Customer\Model\Address\AbstractAddress.
• Create customer via admin ui with address which does not contain street.

Please provide precise scenario you are following.

Thanks

[vovayatsyuk]

Maybe this issue is reproducible at frontend only, I didn't check backend.

1. Open eav_attribute table and change is_required column of street attribute to 0
2. Proceed to checkout at frontend
3. Fill all fields except address lines
4. Press "Next" button.

An error will be returned in response:

```
{
"message":"Unable to save address. Please check input data.",
"trace":"
#0 /app/code/Magento/Checkout/Model/GuestShippingInformationManagement.php(48): Magento\Checkout\Model\ShippingInformationManagement->saveAddressInformation('5', Object(Magento\Checkout\Model\ShippingInformation))
#1 [internal function]: Magento\Checkout\Model\GuestShippingInformationManagement->saveAddressInformation('c67a496c937bfdf...', Object(Magento\Checkout\Model\ShippingInformation))
#2 /app/code/Magento/Webapi/Controller/Rest.php(330): call_user_func_array(Array, Array)
#3 /app/code/Magento/Webapi/Controller/Rest.php(239): Magento\Webapi\Controller\Rest->processApiRequest()
#4 /lib/internal/Magento/Framework/Interception/Interceptor.php(58): Magento\Webapi\Controller\Rest->dispatch(Object(Magento\Framework\App\Request\Http))
#5 /lib/internal/Magento/Framework/Interception/Interceptor.php(138): Magento\Webapi\Controller\Rest\Interceptor->___callParent('dispatch', Array)
#6 /lib/internal/Magento/Framework/Interception/Interceptor.php(153): Magento\Webapi\Controller\Rest\Interceptor->Magento\Framework\Interception\{closure}(Object(Magento\Framework\App\Request\Http))
#7 /generated/code/Magento/Webapi/Controller/Rest/Interceptor.php(39): Magento\Webapi\Controller\Rest\Interceptor->___callPlugins('dispatch', Array, Array)
#8 /lib/internal/Magento/Framework/App/Http.php(135): Magento\Webapi\Controller\Rest\Interceptor->dispatch(Object(Magento\Framework\App\Request\Http))
#9 /lib/internal/Magento/Framework/App/Bootstrap.php(256): Magento\Framework\App\Http->launch()
#10 /index.php(39): Magento\Framework\App\Bootstrap->run(Object(Magento\Framework\App\Http))
#11 {main}
"
}
```

And the following messages will be logged into exception.log:

[2017-08-30 13:57:53] main.CRITICAL: Notice: Array to string conversion in /lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php on line 2999 {"exception":"[object] (Exception(code: 0): Notice: Array to string conversion in /lib/internal/Magento/Framework/DB/Adapter/Pdo/Mysql.php on line 2999 at /lib/internal/Magento/Framework/App/ErrorHandler.php:61)"} []
[2017-08-30 13:57:53] main.CRITICAL: Unable to save address. Please check input data. {"exception":"[object] (Magento\Framework\Exception\InputException(code: 0): Unable to save address. Please check input data. at /app/code/Magento/Quote/Model/ShippingAddressManagement.php:119)"} []

[ishakhsuvarov]

@vovayatsyuk Thank you for the clear and rapid answer

[gwharton]

@vovayatsyuk Is there a way to get this backported into 2.2?

[vovayatsyuk]

Yep, I will create a backport PR shortly