[Backport 2.1] MAGETWO-71697: Fix possible bug when saving address with empty street line #14115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty street line
simpleadm
changed the title
|
Any chance you can also backport the tests? Thanks! |
miguelbalparda
approved these changes
Mar 16, 2018
|
Hi @miguelbalparda, thank you for the review. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Mar 16, 2018
…g address with empty street line #14115
|
Hi @miguelbalparda, How do you think is it ok, to create new PR for missed test? Commited at: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #10582 (MAGETWO-71697) for Magento 2.1
Description
The changes affect address street data preparation to guarantee that street array will be converted to the string.
Manual testing scenarios
As explained in #10582