12110: Missing cascade into attribute set deletion. #12167

nmalevanec · 2017-11-10T09:00:14Z

Description

Fix for: Missing cascade into attribute set deletion.

Fixed Issues (if relevant)

Missing cascade into attribute set deletion #12110: Missing cascade into attribute set deletion

Manual testing scenarios

Create a custom attributes set.
Attach some products to this attributes set.
Got to attributes set admin page.
Delete your custom attributes set.
Confirm you want to remove attached products also.
Check, table url_rewrite should be cleaned from references to removed products.
Check, that new product named like an old one from removed attribute set can be created via API or admin interface.

Contribution checklist

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

sidolov · 2017-12-01T07:25:15Z

Hi @nmalevanec, you in a right way, but problem deeper than an issue with URL rewrites. The main reason why URL rewrites still present in db is foreign key (relations between catalog_product_entity and eav_attribute_set tables). You fix problem with rewrites, but we still has problems with other product artifacts that should be deleted in before, after methods, plugins, observers etc.
Right way to fix this issue is remove foreign key from catalog_product_entity and introduce plugin, that will delete all products from attribute set programatically, in this case all product handlers will be called (for url rewrites - observer: \Magento\CatalogUrlRewrite\Observer\ProductProcessUrlRewriteRemovingObserver).

sidolov · 2017-12-01T07:25:58Z

...code/Magento/CatalogUrlRewrite/Plugin/Eav/AttributeSetRepository/RemoveProductUrlRewrite.php

+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\CatalogUrlRewrite\Plugin\Eav\AttributeSetRepository;


Move plugin to Catalog module

sidolov · 2017-12-01T07:26:35Z

...code/Magento/CatalogUrlRewrite/Plugin/Eav/AttributeSetRepository/RemoveProductUrlRewrite.php

+/**
+ * Remove url rewrites for products with given attribute set.
+ */
+class RemoveProductUrlRewrite


Rename plugin to RemoveProducts

sidolov · 2017-12-01T07:27:06Z

...code/Magento/CatalogUrlRewrite/Plugin/Eav/AttributeSetRepository/RemoveProductUrlRewrite.php

+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function aroundDelete(


Use after plugin instead of around

Sorry, may be I have missed something. But, if I'll use after plugin I won't have attribute set id in results, only bool true and instance of AttributeSetRepository. And I need attribute set id in order to filter product collection.

sidolov · 2017-12-01T07:27:49Z

...code/Magento/CatalogUrlRewrite/Plugin/Eav/AttributeSetRepository/RemoveProductUrlRewrite.php

+        if (!empty($productIds)) {
+            $productIds = array_chunk($productIds, $this->chunkSize);
+            foreach ($productIds as $ids) {
+                $this->urlPersist->deleteByData(


Remove products from db

sidolov · 2017-12-01T13:19:03Z

app/code/Magento/Catalog/Plugin/Model/AttributeSetRepository/RemoveProducts.php

+     *
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     */
+    public function aroundDelete(


Please, use after plugin.
Usage described in http://devdocs.magento.com/guides/v2.2/extension-dev-guide/plugins.html#after-methods

As I wrote above, in after plugin I do not have attribute set id for filtering product collection.

After plugins provide access to all method arguments.

public function afterDelete( AttributeSetRepositoryInterface $subject, $result, AttributeSetInterface $attributeSet ) { // use $attributeSet->getId() ... return $result; }

Fixed. Sorry, for not paying enough attention to devdocs before.

sidolov · 2017-12-04T12:29:43Z

Hi @nmalevanec , consider to port this solution to 2.3 version
Thanks!

sidolov · 2017-12-04T13:07:01Z

Fixed static test (suppress cyclomatic complexity for \Magento\Catalog\Setup\UpgradeSchema::upgrade)

# Conflicts: # app/code/Magento/Catalog/Setup/UpgradeSchema.php

nmalevanec · 2017-12-04T15:01:41Z

@sidolov port on 2.3 - #12538

…2167

[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-84981: Trying to get data from non existent products #12539 - MAGETWO-84979: [Backport 2.2-develop] Fix swagger-ui on instances of Magento running on a non-standard port #12541 - MAGETWO-84903: Added namespace to product videos fotorama events #12469 - MAGETWO-84862: [Backport 2.2-develop] #11409: Too many password reset requests even when disabled in settings #11435 - MAGETWO-84856: Issue 12506: Fixup typo getDispretionPath -> getDispersionPath #12507 - MAGETWO-84808: 12110: Missing cascade into attribute set deletion. #12167 - MAGETWO-83503: [2.2] - Add command to view mview state and queue #12122 - MAGETWO-80223: Fix syntax of expectException() calls #11099

nmalevanec added 3 commits November 9, 2017 16:09

12110: Missing cascade into attribute set deletion.

817bc5f

12110: Missing cascade into attribute set deletion.

5cd2757

12110: Missing cascade into attribute set deletion.

95f11ae

magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 10, 2017

sidolov self-assigned this Nov 30, 2017

sidolov added this to the November 2017 milestone Nov 30, 2017

sidolov added the Release Line: 2.2 label Nov 30, 2017

okorshenko modified the milestones: November 2017, December 2017 Dec 1, 2017

sidolov requested changes Dec 1, 2017

View reviewed changes

Merge branch '2.2-develop' into 12110

14132ce

sidolov added the Progress: needs update label Dec 1, 2017

12110: Missing cascade into attribute set deletion.

88f218d

sidolov requested changes Dec 2, 2017

View reviewed changes

nmalevanec added 2 commits December 4, 2017 11:38

12110: Missing cascade into attribute set deletion.

dd4dec8

12110: Missing cascade into attribute set deletion.

3143bbb

sidolov approved these changes Dec 4, 2017

View reviewed changes

sidolov removed the Progress: needs update label Dec 4, 2017

sidolov added the Progress: accept label Dec 4, 2017

#12167

9df89df

nmalevanec added 2 commits December 4, 2017 15:13

12110: Missing cascade into attribute set deletion.

c14e9e3

Merge remote-tracking branch 'origin/12110' into 12110

c7fbbcc

# Conflicts: # app/code/Magento/Catalog/Setup/UpgradeSchema.php

nmalevanec mentioned this pull request Dec 4, 2017

12111: Missing cascade into attribute set deletion.[port] #12538

Merged

4 tasks

magento-team merged commit c7fbbcc into magento:2.2-develop Dec 7, 2017

magento-team pushed a commit that referenced this pull request Dec 7, 2017

MAGETWO-84808: 12110: Missing cascade into attribute set deletion. #1…

48e3a06

…2167

This was referenced Dec 7, 2017

Fix #10764: delete url rewrites for products after an attribute set is deleted #11391

Closed

Delete Attribute Set is not Deleting product url key in url rewrite #10764

Closed

nmalevanec deleted the 12110 branch August 21, 2018 07:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

12110: Missing cascade into attribute set deletion. #12167

12110: Missing cascade into attribute set deletion. #12167

nmalevanec commented Nov 10, 2017 •

edited by magento-engcom-team

Loading

sidolov commented Dec 1, 2017

sidolov Dec 1, 2017

nmalevanec Dec 4, 2017

sidolov Dec 1, 2017

nmalevanec Dec 4, 2017

sidolov Dec 1, 2017

nmalevanec Dec 4, 2017

sidolov Dec 1, 2017

nmalevanec Dec 4, 2017

sidolov Dec 1, 2017

nmalevanec Dec 4, 2017 •

edited

Loading

sidolov Dec 4, 2017

nmalevanec Dec 4, 2017

sidolov commented Dec 4, 2017

sidolov commented Dec 4, 2017

nmalevanec commented Dec 4, 2017

12110: Missing cascade into attribute set deletion. #12167

12110: Missing cascade into attribute set deletion. #12167

Conversation

nmalevanec commented Nov 10, 2017 • edited by magento-engcom-team Loading

Description

Fixed Issues (if relevant)

Manual testing scenarios

Contribution checklist

sidolov commented Dec 1, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nmalevanec Dec 4, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sidolov commented Dec 4, 2017

sidolov commented Dec 4, 2017

nmalevanec commented Dec 4, 2017

nmalevanec commented Nov 10, 2017 •

edited by magento-engcom-team

Loading

nmalevanec Dec 4, 2017 •

edited

Loading