Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12111: Missing cascade into attribute set deletion.[port] #12538

Merged
merged 1 commit into from
Dec 11, 2017
Merged

12111: Missing cascade into attribute set deletion.[port] #12538

merged 1 commit into from
Dec 11, 2017

Conversation

nmalevanec
Copy link
Contributor

Description

#12167 port on 2.3.0

Fixed Issues (if relevant)

  1. Missing cascade into attribute set deletion #12110: Missing cascade into attribute set deletion

Manual testing scenarios

  1. Create a custom attributes set.
  2. Attach some products to this attributes set.
  3. Got to attributes set admin page.
  4. Delete your custom attributes set.
  5. Confirm you want to remove attached products also.
  6. Check, table url_rewrite should be cleaned from references to removed products.
  7. Check, that new product named like an old one from removed attribute set can be created via API or admin interface.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@nmalevanec nmalevanec mentioned this pull request Dec 4, 2017
Merged
4 tasks
@magento-engcom-team magento-engcom-team added Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 4, 2017
@sidolov sidolov self-assigned this Dec 5, 2017
@sidolov sidolov added this to the December 2017 milestone Dec 5, 2017
@okorshenko okorshenko merged commit a740049 into magento:2.3-develop Dec 11, 2017
okorshenko pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
MAGETWO-85016: 12111: Missing cascade into attribute set deletion.[po…
b90101b 
…rt] #12538
okorshenko pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
Merge pull request #1810 from magento-engcom/develop-prs
a50843f 
[EngCom] Public Pull Requests - develop
 - MAGETWO-85026: [Backport 2.3] #12450: Set Current Store from Store Code if isUseStoreInUrl #12545
 - MAGETWO-85016: 12111: Missing cascade into attribute set deletion.[port] #12538
 - MAGETWO-84980: Trying to get data from non existent products #12540
 - MAGETWO-84933: PR #12466 [BACKPORT 2.3] #12523
@nmalevanec nmalevanec deleted the 12111 branch August 21, 2018 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sidolov sidolov

Labels
Progress: accept Release Line: 2.3 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
5 participants
@nmalevanec @ihor-sviziev @okorshenko @sidolov @magento-engcom-team