Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to get data from non existent products #12540

Merged
merged 1 commit into from
Dec 11, 2017
Merged

Trying to get data from non existent products #12540

merged 1 commit into from
Dec 11, 2017

Conversation

angelo983
Copy link
Member

As requested in #12321

When calling Products in Cart report, it called data of deleted products resulting in exception trying to access $productData[$item->getProductId()]

Preconditions

  1. Magento 2.1.10

Steps to reproduce

  1. Delete a product recently sold
  2. Open Reports > Marketing > Products in Cart

Expected result

  1. List of products

Actual result

  1. Blank list

As requested in #12321

When calling Products in Cart report, it called data of deleted products resulting in exception trying to access $productData[$item->getProductId()]

### Preconditions
<!--- Provide a more detailed information of environment you use -->
<!--- Magento version, tag, HEAD, etc., PHP & MySQL version, etc.. -->
1. Magento 2.1.10

### Steps to reproduce
<!--- Provide a set of unambiguous steps to reproduce this bug include code, if relevant  -->
1. Delete a product recently sold
1. Open Reports > Marketing > Products in Cart

### Expected result
<!--- Tell us what should happen -->
1. List of products

### Actual result
<!--- Tell us what happens instead -->
1. Blank list
@ishakhsuvarov ishakhsuvarov self-assigned this Dec 4, 2017
@ishakhsuvarov ishakhsuvarov added this to the December 2017 milestone Dec 4, 2017
@okorshenko okorshenko merged commit 5fc8d61 into magento:2.3-develop Dec 11, 2017
okorshenko pushed a commit that referenced this pull request Dec 11, 2017
[EngCom] Public Pull Requests - develop
 - MAGETWO-85026: [Backport 2.3] #12450: Set Current Store from Store Code if isUseStoreInUrl #12545
 - MAGETWO-85016: 12111: Missing cascade into attribute set deletion.[port] #12538
 - MAGETWO-84980: Trying to get data from non existent products #12540
 - MAGETWO-84933: PR #12466 [BACKPORT 2.3] #12523
@angelo983 angelo983 deleted the patch-2 branch December 11, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants