Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #12466 [BACKPORT 2.3] #12523

Merged
merged 1 commit into from
Dec 11, 2017
Merged

PR #12466 [BACKPORT 2.3] #12523

merged 1 commit into from
Dec 11, 2017

Conversation

atishgoswami
Copy link
Contributor

@atishgoswami atishgoswami commented Dec 2, 2017 •
edited
Loading

Description

Back-ported PR #12466 for version 2.3

Fixed Issues (if relevant)

None, code improvement

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@atishgoswami atishgoswami mentioned this pull request Dec 2, 2017
Merged
4 tasks
@miguelbalparda miguelbalparda self-assigned this Dec 2, 2017
@miguelbalparda miguelbalparda changed the title Related to PR #12466 [BACKPORT 2.3] PR #12466 [BACKPORT 2.3] Dec 2, 2017
@miguelbalparda
Copy link
Contributor

Thanks a lot @atishgoswami! I'll process this right away! Have a great weekend!

@miguelbalparda miguelbalparda added this to the December 2017 milestone Dec 2, 2017
@okorshenko okorshenko merged commit 960dcca into magento:2.3-develop Dec 11, 2017
okorshenko pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
MAGETWO-84933: PR #12466 [BACKPORT 2.3] #12523
b4651a9
okorshenko pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
Merge pull request #1810 from magento-engcom/develop-prs
a50843f 
[EngCom] Public Pull Requests - develop
 - MAGETWO-85026: [Backport 2.3] #12450: Set Current Store from Store Code if isUseStoreInUrl #12545
 - MAGETWO-85016: 12111: Missing cascade into attribute set deletion.[port] #12538
 - MAGETWO-84980: Trying to get data from non existent products #12540
 - MAGETWO-84933: PR #12466 [BACKPORT 2.3] #12523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miguelbalparda miguelbalparda

Labels
Progress: accept Release Line: 2.3
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@atishgoswami @miguelbalparda @magento-team @okorshenko