Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.3] #12450: Set Current Store from Store Code if isUseStoreInUrl #12545

Merged
merged 1 commit into from
Dec 11, 2017
Merged

[Backport 2.3] #12450: Set Current Store from Store Code if isUseStoreInUrl #12545

merged 1 commit into from
Dec 11, 2017

Conversation

osrecio
Copy link
Member

@osrecio osrecio commented Dec 5, 2017 •
edited
Loading

Set Current Store from Store Code

Description

If use Store Code in Url but for some reason is empty after process, set Store_Code from Store

Fixed Issues (if relevant)

  1. Store not found when adding a ? to site URL. #12450: Store not found when adding a ? to site URL

Manual testing scenarios

  1. Turn on "Add storecode to URL's" in "Configuration > General > Web"
  2. Navigate in browser to {BASE_URL}/?
  3. Error thrown

Backport

  1. #12450: Set Current Store from Store Code if isUseStoreInUrl #12529: Set Current Store from Store Code if isUseStoreInUrl

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Dec 5, 2017
@orlangur orlangur self-assigned this Dec 5, 2017
@orlangur orlangur added this to the December 2017 milestone Dec 5, 2017
@okorshenko okorshenko merged commit e9bbe2f into magento:2.3-develop Dec 11, 2017
okorshenko pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
MAGETWO-85026: [Backport 2.3] #12450: Set Current Store from Store Co…
da06384 
…de if isUseStoreInUrl #12545
okorshenko pushed a commit that referenced this pull request Dec 11, 2017
@ishakhsuvarov
Merge pull request #1810 from magento-engcom/develop-prs
a50843f 
[EngCom] Public Pull Requests - develop
 - MAGETWO-85026: [Backport 2.3] #12450: Set Current Store from Store Code if isUseStoreInUrl #12545
 - MAGETWO-85016: 12111: Missing cascade into attribute set deletion.[port] #12538
 - MAGETWO-84980: Trying to get data from non existent products #12540
 - MAGETWO-84933: PR #12466 [BACKPORT 2.3] #12523
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orlangur orlangur orlangur approved these changes

Assignees

@orlangur orlangur

Labels
Award: test coverage Progress: accept Release Line: 2.3 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
December 2017
Development

Successfully merging this pull request may close these issues.
6 participants
@osrecio @orlangur @magento-team @vkublytskyi @okorshenko @magento-engcom-team