Shipping method fixtures not compatible with getShippingMethod(true) in OrderCreateTest #12227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
magento-team
pushed a commit
that referenced
this pull request
Nov 25, 2017
…ngMethod(true) in OrderCreateTest #12227
magento-team
pushed a commit
that referenced
this pull request
Nov 25, 2017
[EngCom] Public Pull Requests - 2.2-develop - MAGETWO-83552: save invoice ID on credit memo when using API method salesRefundInvoiceV1 #11670 - MAGETWO-82577: [Backport 2.2] Translate order getCreatedAtFormatted() to store locale #11422 - MAGETWO-84474: 10128: New Orders not being saved to order grid #12241 - MAGETWO-83783: Shipping method fixtures not compatible with getShippingMethod(true) in OrderCreateTest #12227 - MAGETWO-83290: Add swatch option: Prevent loosing data and default value if data is not populated via adminhtml #12036 - MAGETWO-83741: 11740: Sending emails from Admin in Multi-Store Environment defaults to Primary Store #11992 - MAGETWO-83399: Fix for remove 'product_list_toolbar' block from layout in XML #9413 #11473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test
Magento\Sales\Service\V1\OrderCreateTesthas an incorrect shipping method fixture which produces an error when ever something tries to get the orders shipping method as an object.e.g.
$order->getShippingMethod(true);Notice: Undefined offset: 1 in /magento2/app/code/Magento/Sales/Model/Order.php on line 1194Fixed Issues (if relevant)
N/A
Manual testing scenarios
$order->getShippingMethod(true);Notice: Undefined offset: 1 in /magento2/app/code/Magento/Sales/Model/Order.php on line 1194Contribution checklist