Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10128: New Orders not being saved to order grid #12241

Merged
merged 5 commits into from
Nov 25, 2017
Merged

10128: New Orders not being saved to order grid #12241

merged 5 commits into from
Nov 25, 2017

Conversation

RomaKis
Copy link
Contributor

@RomaKis RomaKis commented Nov 14, 2017

New Orders not being saved to order grid

Fixed Issues (if relevant)

  1. New Orders not being saved to order grid #10128: New Orders not being saved to order grid

Manual testing scenarios

  1. Go to Storefront
  2. Add Product to the Card as Guest
  3. Go to Checkout
  4. Fill all required fields
  5. Choose internal payment method "Check/Money order"
  6. Click Place Order button
  7. Log in to Admin
  8. Go to Dashboard

Actual result:
-Dashboard shows orders as "Guest"
Expected result:
-Dashboard should show order with customer name

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added bugfix Component: Payment Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 14, 2017
@@ -92,7 +92,7 @@ protected function _prepareCollection()
protected function _afterLoadCollection()
{
foreach ($this->getCollection() as $item) {
$item->getCustomer() ?: $item->setCustomer('Guest');
$item->getCustomer() ?: $item->setCustomer($item->getBillingAddress()->getName());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason to get customer name from the Billing Address?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishakhsuvarov, as it is guest, so he has only shipping and billing addresses. I think it is more reasonably to take it from billing than from shipping.
Also I checked the mail message after I had placed order as guest. It also takes name from billing address.

@ishakhsuvarov ishakhsuvarov added this to the November 2017 milestone Nov 24, 2017
@magento-team magento-team merged commit f8ed60f into magento:2.2-develop Nov 25, 2017
magento-team pushed a commit that referenced this pull request Nov 25, 2017
[EngCom] Public Pull Requests - 2.2-develop
 - MAGETWO-83552: save invoice ID on credit memo when using API method salesRefundInvoiceV1 #11670
 - MAGETWO-82577: [Backport 2.2] Translate order getCreatedAtFormatted() to store locale #11422
 - MAGETWO-84474: 10128: New Orders not being saved to order grid #12241
 - MAGETWO-83783: Shipping method fixtures not compatible with getShippingMethod(true) in OrderCreateTest #12227
 - MAGETWO-83290: Add swatch option: Prevent loosing data and default value if data is not populated via adminhtml #12036
 - MAGETWO-83741: 11740: Sending emails from Admin in Multi-Store Environment defaults to Primary Store #11992
 - MAGETWO-83399: Fix for remove 'product_list_toolbar' block from layout in XML #9413 #11473
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Component: Payment Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants