Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Implement customer group grid on ui component #13501

Merged
merged 5 commits into from
Jul 7, 2018
Merged

[Improvement] Implement customer group grid on ui component #13501

merged 5 commits into from
Jul 7, 2018

Conversation

simpleadm
Copy link
Contributor

@simpleadm simpleadm commented Feb 5, 2018 •
edited
Loading

Description

Several versions ago backend grid widgets (\Magento\Backend\Block\Widget\Grid) were marked as
deprecated in favour of UI component implementation. This PR refactors customer group grid to use UI components.
At least it will save time of third party developers who needs to extend customer groups grid :)

Manual testing scenarios

Before changes:
image

After changes:
image
Filers:
image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko closed this Feb 8, 2018
@okorshenko okorshenko changed the base branch from develop to 2.3-develop February 8, 2018 17:06
@okorshenko okorshenko reopened this Feb 8, 2018
@simpleadm simpleadm mentioned this pull request Feb 28, 2018
Closed
4 tasks
@simpleadm simpleadm requested a review from okorshenko February 28, 2018 19:12
@VladimirZaets
Merge branch 'customer-grid-ui-component' of github.com:simpleadm/mag…
20e49f7 
…ento2 into customer-grid-ui-component

# Conflicts:
#	app/code/Magento/Customer/etc/di.xml
@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Apr 17, 2018 •
edited
Loading

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ simpleadm
❌ VladimirZaets

@VladimirZaets VladimirZaets reopened this Apr 17, 2018
@VladimirZaets VladimirZaets changed the base branch from 2.3-develop to 2.2-develop April 17, 2018 13:28
@VladimirZaets VladimirZaets changed the base branch from 2.2-develop to 2.3-develop April 17, 2018 13:28
@magento-engcom-team magento-engcom-team added this to the April 2018 milestone Apr 17, 2018
@VladimirZaets
Copy link
Contributor

Hi @simpleadm , please fix failed Travis tests.
Also, please try to run next functional tests, because they fail with your changes:
Magento\Customer\Test\TestCase\DeleteSystemCustomerGroupTest.test with data set "DeleteSystemCustomerGroup1_0"
Magento\Customer\Test\TestCase\DeleteSystemCustomerGroupTest.test with data set "DeleteSystemCustomerGroup2_0"
Magento\Customer\Test\TestCase\LoginOnFrontendFailTest.test with data set "LoginOnFrontendFailTestVariation1_0"
Magento\Customer\Test\TestCase\MassAssignCustomerGroupTest.test with data set "MassAssignCustomerGroupTestVariation1_0"
Magento\Customer\Test\TestCase\VerifyDisabledCustomerGroupFieldTest.test with data set "VerifyDisabledCustomerGroupField1_0"

If you need some help or guide how to running functional tests locally, please let us know.

@okorshenko okorshenko modified the milestones: April 2018, May 2018 May 18, 2018
@okorshenko okorshenko removed this from the May 2018 milestone May 31, 2018
@VladimirZaets
Copy link
Contributor

Hi @simpleadm. Can you please resolve conflicts with 2.3-develop branch. Thanks

@simpleadm
Copy link
Contributor Author

Hi @VladimirZaets ,
Conflicts were resolved and functional tests passed.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.0 milestone Jun 25, 2018
@magento-engcom-team magento-engcom-team added Partner: Convert partners-contribution Pull Request is created by Magento Partner labels Jun 25, 2018
@magento-engcom-team magento-engcom-team merged commit ff243e6 into magento:2.3-develop Jul 7, 2018
magento-engcom-team pushed a commit that referenced this pull request Jul 7, 2018
ENGCOM-1312: [Improvement] Implement customer group grid on ui compon…
1480d23 
…ent #13501
magento-engcom-team pushed a commit that referenced this pull request Jul 7, 2018
ENGCOM-1312: [Improvement] Implement customer group grid on ui compon…
4eb0223 
…ent #13501
magento-engcom-team pushed a commit that referenced this pull request Jul 7, 2018
ENGCOM-1312: [Improvement] Implement customer group grid on ui compon…
540a6af 
…ent #13501
@magento-engcom-team
Copy link
Contributor

Hi @simpleadm. Thank you for your contribution.
We will aim to release these changes as part of 2.3.0.
Please check the release notes for final confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okorshenko okorshenko Awaiting requested review from okorshenko

Assignees

@VladimirZaets VladimirZaets

Labels
Area: Frontend Award: advanced Component: Customer improvement Partner: Convert partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3
Projects
None yet
Milestone
Release: 2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@simpleadm @magento-cicd2 @VladimirZaets @magento-engcom-team @okorshenko