-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Implement customer group form on ui component #13887
[Improvement] Implement customer group form on ui component #13887
Conversation
Hi @simpleadm thank you for this improvement. We will start review process now |
Please pay attention about backward compatibility in save controller and let me know if it should be fixed. And what about integration tests for it? |
Hi @simpleadm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, fix broken tests
Hi @simpleadm , any updates? |
Hi @sidolov , |
Hi @simpleadm , thanks for the information! |
Sorry, hope to start this task on current week :( |
Hi @simpleadm , do you have some update? |
@simpleadm , I am closing this PR now due to inactivity. |
Description
Several versions ago backend form widgets (
\Magento\Backend\Block\Widget\Form
) were marked asdeprecated in favour of UI component implementation. This PR refactors customer group form to use UI components. Also was added "Save and Continue Edit" button.
At least it will save time of third party developers who needs to extend customer groups form :)
Customer group grid was implemented in scope of #13501
Manual testing scenarios
Before changes:
After changes:
Contribution checklist