Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Implement customer group form on ui component #13887

Conversation

simpleadm
Copy link
Contributor

@simpleadm simpleadm commented Feb 28, 2018

Description

Several versions ago backend form widgets (\Magento\Backend\Block\Widget\Form) were marked as
deprecated in favour of UI component implementation. This PR refactors customer group form to use UI components. Also was added "Save and Continue Edit" button.
At least it will save time of third party developers who needs to extend customer groups form :)

Customer group grid was implemented in scope of #13501

Manual testing scenarios

Before changes:
image

After changes:
image

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko
Copy link
Contributor

Hi @simpleadm thank you for this improvement. We will start review process now

@simpleadm
Copy link
Contributor Author

simpleadm commented Feb 28, 2018

Please pay attention about backward compatibility in save controller and let me know if it should be fixed.

And what about integration tests for it?

@okorshenko
Copy link
Contributor

Hi @simpleadm
We are ok with renaming request parameter for the controller in release 2.3.0. This might affect some tests, but we will try to fix them as well. New code must be covered with tests (unit or integration).
Please stabilize your current implementation and tests. Once branch is stable, we will proceed with testing and acceptance

Copy link
Contributor

@okorshenko okorshenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix broken tests

@okorshenko okorshenko assigned sidolov and unassigned okorshenko Mar 15, 2018
@sidolov
Copy link
Contributor

sidolov commented Mar 29, 2018

Hi @simpleadm , any updates?

@simpleadm
Copy link
Contributor Author

Hi @sidolov ,
I will be able continue this task next week

@sidolov
Copy link
Contributor

sidolov commented Apr 3, 2018

Hi @simpleadm , thanks for the information!

@simpleadm
Copy link
Contributor Author

Sorry, hope to start this task on current week :(

@VladimirZaets
Copy link
Contributor

Hi @simpleadm , do you have some update?

@okorshenko okorshenko modified the milestones: April 2018, May 2018 May 18, 2018
@okorshenko okorshenko removed this from the May 2018 milestone May 31, 2018
@sidolov
Copy link
Contributor

sidolov commented Jun 2, 2018

@simpleadm , I am closing this PR now due to inactivity.
Please reopen and update if you wish to continue.
Thank you for collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants